[coreboot-gerrit] New patch to review for coreboot: acpigen_write_package: Return pointer to package element counter

Duncan Laurie (dlaurie@chromium.org) gerrit at coreboot.org
Sun Jul 3 05:07:44 CEST 2016


Duncan Laurie (dlaurie at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/15536

-gerrit

commit f115431650c797dc1b81079aac244d788f34ce90
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Sat Jul 2 19:53:54 2016 -0700

    acpigen_write_package: Return pointer to package element counter
    
    Have acpigen_write_package() return a pointer to the package element
    counter so it can be used for dynamic package generation.
    
    Change-Id: Id7f6dd03511069211ba3ee3eb29a6ca1742de847
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/arch/x86/acpigen.c              | 5 ++++-
 src/arch/x86/include/arch/acpigen.h | 2 +-
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/arch/x86/acpigen.c b/src/arch/x86/acpigen.c
index c370321..d37568c 100644
--- a/src/arch/x86/acpigen.c
+++ b/src/arch/x86/acpigen.c
@@ -87,12 +87,15 @@ void acpigen_emit_dword(unsigned int data)
 	acpigen_emit_byte((data >> 24) & 0xff);
 }
 
-void acpigen_write_package(int nr_el)
+char *acpigen_write_package(int nr_el)
 {
+	char *p;
 	/* package op */
 	acpigen_emit_byte(0x12);
 	acpigen_write_len_f();
+	p = acpigen_get_current();
 	acpigen_emit_byte(nr_el);
+	return p;
 }
 
 void acpigen_write_byte(unsigned int data)
diff --git a/src/arch/x86/include/arch/acpigen.h b/src/arch/x86/include/arch/acpigen.h
index 9e6ef29..9035f27 100644
--- a/src/arch/x86/include/arch/acpigen.h
+++ b/src/arch/x86/include/arch/acpigen.h
@@ -38,7 +38,7 @@ void acpigen_write_len_f(void);
 void acpigen_pop_len(void);
 void acpigen_set_current(char *curr);
 char *acpigen_get_current(void);
-void acpigen_write_package(int nr_el);
+char *acpigen_write_package(int nr_el);
 void acpigen_write_zero(void);
 void acpigen_write_one(void);
 void acpigen_write_ones(void);



More information about the coreboot-gerrit mailing list