[coreboot-gerrit] Patch merged into coreboot/master: drivers/generic/max98357a: Fix naming and ACPI path handling

gerrit at coreboot.org gerrit at coreboot.org
Sat Jul 2 01:19:48 CEST 2016


the following patch was just integrated into master:
commit 366cd21472bec6bbb412ebdad10df327a58eb00f
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Wed Jun 29 22:34:01 2016 -0700

    drivers/generic/max98357a: Fix naming and ACPI path handling
    
    The upstream kernel driver is not using the of-style naming for
    sdmode-gpio so remove the maxim prefix, and remove the duplicate
    entry for the sdmode-delay value as well.
    
    Also fix the usage of the path variable, since the device path uses
    a static variable it can't be assigned that early or it will be
    overwritten by later calls.
    
    This results in the following output for the _DSD when tested on
    reef mainboard:
    
    Name (_DSD, Package (0x02)
    {
        ToUUID ("daffd814-6eba-4d8c-8a91-bc9bbf4aa301")
        Package (0x02)
        {
            Package (0x02)
            {
                "sdmode-gpio",
                Package (0x04)
                {
                    \_SB.PCI0.HDAS.MAXM,
                    Zero,
                    Zero,
                    Zero
                }
            },
            Package (0x02)
            {
                "sdmode-delay",
                Zero
            }
        }
    })
    
    Change-Id: Iab33182a5f64c89151966f5e79f4f7c30840c46f
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
    Reviewed-on: https://review.coreboot.org/15514
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See https://review.coreboot.org/15514 for details.

-gerrit



More information about the coreboot-gerrit mailing list