[coreboot-gerrit] Patch merged into coreboot/master: board_status/getrevision.sh: get rid of colons in dir names

gerrit at coreboot.org gerrit at coreboot.org
Fri Jan 29 16:56:36 CET 2016


the following patch was just integrated into master:
commit b2cc1299af4af202069ef6fbbdb14a73bdff3b4f
Author: Martin Roth <martinroth at google.com>
Date:   Wed Jan 27 09:53:45 2016 -0700

    board_status/getrevision.sh: get rid of colons in dir names
    
    Gnu make won't build in directories that have a colon in their name.
    
    When the makefile expands a variable containing a dirctory name that
    has colons in it, it seems to interpret that as a makefile target, and
    fails the build.
    
    Many other characters also confuse the makefiles, including spaces,
    ampersand symbols, dollar signs, etc.
    
    I've started including scripts into the board-status directories to
    do the build of the rom that was tested, and this is preventing them
    from working without renaming the directory before doing the build.
    
    Change-Id: I9dd8e4027be21363015cd8df9918610e206afce2
    Signed-off-by: Martin Roth <martinroth at google.com>
    Reviewed-on: https://review.coreboot.org/13490
    Tested-by: build bot (Jenkins)
    Reviewed-by: David Hendricks <dhendrix at chromium.org>
    Reviewed-by: Patrick Georgi <pgeorgi at google.com>


See https://review.coreboot.org/13490 for details.

-gerrit



More information about the coreboot-gerrit mailing list