[coreboot-gerrit] Patch set updated for coreboot: mb/gigabyte/ga-g41m-es2l: Remove PMBASE settings and commented code.

Damien Zammit (damien@zamaudio.com) gerrit at coreboot.org
Wed Jan 27 03:57:37 CET 2016


Damien Zammit (damien at zamaudio.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13466

-gerrit

commit 5c944a5f733cc94c5e36be0a3692a89705b9294e
Author: Damien Zammit <damien at zamaudio.com>
Date:   Tue Jan 26 17:24:48 2016 +1100

    mb/gigabyte/ga-g41m-es2l: Remove PMBASE settings and commented code.
    
    Fixed incorrect comment regarding port 80 LPC route.
    
    Change-Id: Ifbb73753d5a0737418b869085f2329a02504e5dc
    Signed-off-by: Damien Zammit <damien at zamaudio.com>
---
 src/mainboard/gigabyte/ga-g41m-es2l/romstage.c | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/romstage.c b/src/mainboard/gigabyte/ga-g41m-es2l/romstage.c
index ca8ca5c..bff481f 100644
--- a/src/mainboard/gigabyte/ga-g41m-es2l/romstage.c
+++ b/src/mainboard/gigabyte/ga-g41m-es2l/romstage.c
@@ -58,21 +58,6 @@ static void mb_gpio_init(void)
 	outl(0x000000f0, DEFAULT_GPIOBASE + 0x34);
 	outl(0x00000083, DEFAULT_GPIOBASE + 0x38);
 
-	/* Set default power management registers */
-	pci_write_config32(dev, PMBASE, DEFAULT_PMBASE | 1);
-	outw(0x0011, DEFAULT_PMBASE + 0x00);
-	outw(0x0120, DEFAULT_PMBASE + 0x02);
-	outl(0x00001c01, DEFAULT_PMBASE + 0x04);
-	outl(0x00bb29d2, DEFAULT_PMBASE + 0x08);
-	outl(0x000000a0, DEFAULT_PMBASE + 0x10);
-	outl(0xc5000000, DEFAULT_PMBASE + 0x28);
-	outl(0x00000040, DEFAULT_PMBASE + 0x2c);
-	outw(0x13e0, DEFAULT_PMBASE + 0x44);
-	outw(0x003f, DEFAULT_PMBASE + 0x60);
-	outw(0x0800, DEFAULT_PMBASE + 0x68);
-	outw(0x0008, DEFAULT_PMBASE + 0x6a);
-	outw(0x003f, DEFAULT_PMBASE + 0x72);
-
 	/* Set default GPIOs on superio */
 	ite_reg_write(GPIO_DEV, 0x25, 0x00);
 	ite_reg_write(GPIO_DEV, 0x26, 0xc7);
@@ -137,8 +122,8 @@ void main(unsigned long bist)
 	//                          ch0      ch1
 	const u8 spd_addrmap[4] = { 0x50, 0, 0x52, 0 };
 
-	/* Disable watchdog timer and route port 80 to LPC */
-	RCBA32(0x3410) = (RCBA32(0x3410) | 0x20);// & ~0x4;
+	/* Disable watchdog timer */
+	RCBA32(0x3410) = RCBA32(0x3410) | 0x20;
 
 	/* Set southbridge and Super I/O GPIOs. */
 	mb_gpio_init();



More information about the coreboot-gerrit mailing list