[coreboot-gerrit] Patch set updated for coreboot: drivers/intel/fsp2_0: Update FspUpdVpd header and adjust wrapper code
Alexandru Gagniuc (mr.nuke.me@gmail.com)
gerrit at coreboot.org
Tue Jan 26 19:06:38 CET 2016
Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13354
-gerrit
commit dd0b067c961bd3c50ef98a9a87c1954b8267efaf
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date: Wed Nov 11 13:02:18 2015 -0800
drivers/intel/fsp2_0: Update FspUpdVpd header and adjust wrapper code
As of this writing, the FSP2.0 ABI is not fully defined, and this is
why wrapper code needs to be adjusted with this header update.
Change-Id: I47a1e36a4a0481162976800950bc856094f25711
Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
src/drivers/intel/fsp2_0/include/fsp/FspUpdVpd.h | 361 +++++++++--------------
src/drivers/intel/fsp2_0/memory_init.c | 6 +-
src/drivers/intel/fsp2_0/silicon_init.c | 5 +-
3 files changed, 142 insertions(+), 230 deletions(-)
diff --git a/src/drivers/intel/fsp2_0/include/fsp/FspUpdVpd.h b/src/drivers/intel/fsp2_0/include/fsp/FspUpdVpd.h
index bdd5999..b3e2b6b 100644
--- a/src/drivers/intel/fsp2_0/include/fsp/FspUpdVpd.h
+++ b/src/drivers/intel/fsp2_0/include/fsp/FspUpdVpd.h
@@ -110,338 +110,253 @@ struct BL_GPIO_PAD_INIT {
+#define FSP_TEMP_RAM_INIT_UPD_SIGNATURE 0x4450555F54505346 /* 'FSPT_UPD' */
+#define FSP_MEMORY_INIT_UPD_SIGNATURE 0x4450555F4D505346 /* 'FSPM_UPD' */
+#define FSP_SILICON_INIT_UPD_SIGNATURE 0x4450555F53505346 /* 'FSPS_UPD' */
+
struct TEMP_RAM_INIT_UPD {
-/** Offset 0x0020
+/** Offset 0x0000
**/
uint64_t Signature;
-/** Offset 0x0028
+/** Offset 0x0008
**/
uint8_t Revision;
-/** Offset 0x0029
+/** Offset 0x0009
**/
- uint8_t UnusedUpdSpace0[83];
-/** Offset 0x007C
+ uint8_t UnusedUpdSpace0[67];
+/** Offset 0x004C
**/
uint32_t ReservedTempRamInitUpd;
} __attribute__((packed));
struct MEMORY_INIT_UPD {
-/** Offset 0x0080
+/** Offset 0x0000
**/
uint64_t Signature;
-/** Offset 0x0088
+/** Offset 0x0008
**/
uint8_t Revision;
-/** Offset 0x0089
+/** Offset 0x0009
**/
- uint8_t UnusedUpdSpace1[7];
-/** Offset 0x0090
+ uint8_t UnusedUpdSpace0[23];
+/** Offset 0x0020
Debug Serial Port Base
- Debug serial port resource base address, either I/O or MMIO base.
+ Debug serial port base address. This option will be used only when the 'Serial Port Debug Device' option is set to 'External Device'.
**/
uint32_t SerialDebugPortAddress;
-/** Offset 0x0094
+/** Offset 0x0024
Debug Serial Port Type
- Debug serial port resource type. NONE means no serial port support.
+ 16550 compatible debug serial port resource type. NONE means no serial port support.
**/
uint8_t SerialDebugPortType;
-/** Offset 0x0095
+/** Offset 0x0025
Serial Port Debug Device
- Select active serial port device. For SOC UART devices,'Debug Serial Port Base' options will be ignored.
+ Select active serial port device for debug. For SOC UART devices,'Debug Serial Port Base' options will be ignored.
**/
uint8_t SerialDebugPortDevice;
-/** Offset 0x0096
+/** Offset 0x0026
Debug Serial Port Stride Size
- Debug serial port register map stride size.
+ Debug serial port register map stride size in bytes.
**/
uint8_t SerialDebugPortStrideSize;
-/** Offset 0x0097
+/** Offset 0x0027
**/
- uint8_t ReservedUpd1;
-/** Offset 0x0098
- Memory FastBootSupport
- MRC Fast Boot Support
+ uint8_t UnusedUpdSpace1;
+/** Offset 0x0028
+ Memory Fast Boot
+ Enable/Disable MRC fast boot support.
**/
uint8_t MrcFastBoot;
-/** Offset 0x0099
-**/
- uint8_t UnusedUpdSpace2[7];
-/** Offset 0x00A0
- Memory EccSupport
- ECC Support
-**/
- uint8_t EccSupport;
-/** Offset 0x00A1
- Memory DdrFreqLimit
- DDR Freq Limit
-**/
- uint8_t DdrFreqLimit;
-/** Offset 0x00A2
- Memory MaxTolud
- MaxTolud
-**/
- uint32_t MaxTolud;
-/** Offset 0x00A6
- MrcDebugMsgLevel
- Set MRC DebugMsg Level
+/** Offset 0x0029
**/
- uint8_t MrcDebugMsgLevel;
-/** Offset 0x00A7
+ uint8_t UnusedUpdSpace2[103];
+/** Offset 0x0090
Integrated Graphics Device
- Enable : Enable Integrated Graphics Device (IGD) when selected as the Primary Video Adaptor. Disable: Alwarys disable IGD
+ Enable : Enable Integrated Graphics Device (IGD) when selected as the Primary Video Adaptor. Disable: Always disable IGD.
**/
uint8_t Igd;
-/** Offset 0x00A8
+/** Offset 0x0091
DVMT Pre-Allocated
- Select DVMT 5.0 Pre-Allocated (Fixed) Graphics Memory size used by the Internal Graphics Device
+ Select DVMT 5.0 Pre-Allocated (Fixed) Graphics Memory size used by the Internal Graphics Device.
**/
uint8_t IgdDvmt50PreAlloc;
-/** Offset 0x00A9
+/** Offset 0x0092
Aperture Size
- Select the Aperture Size.
+ Select the Aperture Size used by the Internal Graphics Device.
**/
uint8_t IgdApertureSize;
-/** Offset 0x00AA
+/** Offset 0x0093
GTT Size
- Select the GTT Size.
+ Select the GTT Size used by the Internal Graphics Device.
**/
uint8_t GTTSize;
-/** Offset 0x00AB
+/** Offset 0x0094
Primary Display
Select which of IGD/PCI Graphics device should be Primary Display.
**/
uint8_t PrimaryVideoAdaptor;
-/** Offset 0x00AC
+/** Offset 0x0095
+ GT PM Support
+ Enable/Disable GT power management support.
**/
uint8_t PmSupport;
-/** Offset 0x00AD
+/** Offset 0x0096
+ RC6(Render Standby)
+ Enable/Disable render standby support.
**/
uint8_t EnableRenderStandby;
-/** Offset 0x00AE
+/** Offset 0x0097
+ PAVP Enable
+ Enable/Disable Protected Audio Visual Path (PAVP).
**/
uint8_t PavpEnable;
-/** Offset 0x00AF
+/** Offset 0x0098
**/
- uint8_t SataEnable;
-/** Offset 0x00B0
+ uint8_t UnusedUpdSpace3[116];
+/** Offset 0x010C
+ OEM File Loading Address
+ Determine the memory base address to load a specified file from CSE file system after memory is available.
+**/
+ uint32_t ObbLoadingBase;
+/** Offset 0x0110
+ OEM file name to load
+ Specify a file name to load from CSE file system after memory is available. Empty indicates no file needs to be loaded.
+**/
+ uint8_t ObbFileName[16];
+/** Offset 0x0120
+**/
+ uint8_t UnusedUpdSpace4[48];
+/** Offset 0x0150
+ GPIO Table Pointer
+ GPIO table pointer to a BL_GPIO_PAD_INIT structure.
+**/
+ struct BL_GPIO_PAD_INIT* GpioPadInitTablePtr;
+/** Offset 0x0154
+**/
+ uint8_t UnusedUpdSpace5[56];
+/** Offset 0x018C
+**/
+ uint32_t ReservedMemoryInitUpd;
+} __attribute__((packed));
+
+struct SILICON_INIT_UPD {
+/** Offset 0x0000
+**/
+ uint64_t Signature;
+/** Offset 0x0008
+**/
+ uint8_t Revision;
+/** Offset 0x0009
+**/
+ uint8_t UnusedUpdSpace0[23];
+/** Offset 0x0020
+ Enable SD controller
+ Enable/disable SD Card controller.
+**/
+ uint8_t SdcardEnabled;
+/** Offset 0x0021
+ Enable SDIO controller
+ Enable/disable SDIO controller.
+**/
+ uint8_t SdioEnabled;
+/** Offset 0x0022
+ Enable eMMC controller
+ Enable/disable eMMC controller.
+**/
+ uint8_t eMMCEnabled;
+/** Offset 0x0023
+**/
+ uint8_t UnusedUpdSpace1[93];
+/** Offset 0x0080
Enable SATA
Enable/disable SATA controller.
**/
uint8_t EnableSata;
-/** Offset 0x00B1
+/** Offset 0x0081
SATA Mode
Select SATA controller working mode.
**/
uint8_t SataMode;
-/** Offset 0x00B2
- Enable SATA
- Enable/disable SATA controller.
+/** Offset 0x0082
+ Aggressive SATA LPM Support
+ Enable SOC to aggressively enter link power state for SATA.
**/
uint8_t SataSalpSupport;
-/** Offset 0x00B3
+/** Offset 0x0083
Enable SATA ports
Enable/disable SATA ports. One byte for each port, byte0 for port0, byte1 for port1, and so on.
**/
uint8_t SataPortsEnable[2];
-/** Offset 0x00B5
+/** Offset 0x0085
Enable SATA DEVSLP Feature
Enable/disable SATA DEVSLP per port. 0 is disable, 1 is enable. One byte for each port, byte0 for port0, byte1 for port1, and so on.
**/
uint8_t SataPortsDevSlp[2];
-/** Offset 0x00B7
+/** Offset 0x0087
Enable PCIE RP
Enable/disable PCIE Root Ports. 0: disable, 1: enable. One byte for each port, byte0 for port1, byte1 for port2, and so on.
**/
uint8_t PcieRpEnable[6];
-/** Offset 0x00BD
+/** Offset 0x008D
Configure CLKREQ Number
- Configure Root Port CLKREQ Number if CLKREQ is supported. Each value in arrary can be between 0-6. One byte for each port, byte0 for port1, byte1 for port2, and so on.
+ Configure Root Port CLKREQ Number if CLKREQ is supported. Each value in array can be between 0-6. One byte for each port, byte0 for port1, byte1 for port2, and so on.
**/
uint8_t PcieRpClkReqNumber[6];
-/** Offset 0x00C3
+/** Offset 0x0093
Enable USB2 ports
Enable/disable per USB2 ports. One byte for each port, byte0 for port0, byte1 for port1, and so on.
**/
uint8_t PortUsb20Enable[8];
-/** Offset 0x00CB
+/** Offset 0x009B
Enable USB3 ports
Enable/disable per USB3 ports. One byte for each port, byte0 for port0, byte1 for port1, and so on.
**/
uint8_t PortUsb30Enable[6];
-/** Offset 0x00D1
+/** Offset 0x00A1
Enable XHCI SSIC Eanble
Enable/disable XHCI SSIC port.
**/
uint8_t SsicPortEnable;
-/** Offset 0x00D2
+/** Offset 0x00A2
Enable SMBus
Enable/disable SMBus controller.
**/
uint8_t SmbusEnable;
-/** Offset 0x00D3
+/** Offset 0x00A3
**/
- uint8_t UnusedUpdSpace3[13];
-/** Offset 0x00E0
+ uint8_t UnusedUpdSpace2[13];
+/** Offset 0x00B0
+ ISP Enable/Disable
+ Enable/Disable ISP Device.
**/
uint8_t IspEn;
-/** Offset 0x00E1
-**/
- uint8_t IspAcpiMode;
-/** Offset 0x00E2
-**/
- uint32_t AdditionalFvBase;
-/** Offset 0x00E6
-**/
- uint8_t UnusedUpdSpace4[122];
-/** Offset 0x0160
-**/
- uint32_t ObbLoadingBase;
-/** Offset 0x0164
-**/
- uint32_t ObbFlashBase;
-/** Offset 0x0168
-**/
- uint32_t ObbFlashSize;
-/** Offset 0x016C
-**/
- uint8_t UnusedUpdSpace5[20];
-/** Offset 0x0180
-**/
- uint8_t ObbFileName[16];
-/** Offset 0x0190
-**/
- uint8_t UnusedUpdSpace6[48];
-/** Offset 0x01C0
-**/
- struct BL_GPIO_PAD_INIT* GpioPadInitTablePtr;
-/** Offset 0x01C4
-**/
- uint8_t UnusedUpdSpace7[56];
-/** Offset 0x01FC
-**/
- uint32_t ReservedMemoryInitUpd;
-} __attribute__((packed));
-
-struct SILICON_INIT_UPD {
-/** Offset 0x0200
-**/
- uint64_t Signature;
-/** Offset 0x0208
+/** Offset 0x00B1
**/
- uint8_t Revision;
-/** Offset 0x0209
+ uint8_t UnusedUpdSpace3[303];
+/** Offset 0x01E0
+ BMP Logo Data Size
+ BMP logo data buffer size.
**/
- uint8_t UnusedUpdSpace8[7];
-/** Offset 0x0210
- Logo Pointer
- Points to PEI Display Logo Image
+ uint32_t LogoSize;
+/** Offset 0x01E4
+ BMP Logo Data Pointer
+ BMP logo data pointer to a BMP format buffer.
**/
uint32_t LogoPtr;
-/** Offset 0x0214
- Logo Size
- Size of PEI Display Logo Image
-**/
- uint32_t LogoSize;
-/** Offset 0x0218
- Graphics Configuration Ptr
- Points to VBT
+/** Offset 0x01E8
+ Graphics Configuration Data Pointer
+ Graphics configuration data used for initialization.
**/
uint32_t GraphicsConfigPtr;
-/** Offset 0x021C
- Enable HD Audio DSP
- Enable/disable HD Audio DSP feature.
-**/
- uint8_t DspEnable;
-/** Offset 0x021D
- Select HDAudio IoBuffer Ownership
- Select HDAudio IoBuffer Ownership.
-**/
- uint8_t IoBufferOwnership;
-/** Offset 0x021E
- BXT PlatformType
- BXT PlatformType.
-**/
- uint8_t PlatformType;
-/** Offset 0x021F
- DynSR
- Enable/disable DynSR feature.
-**/
- uint8_t DynSR;
-/** Offset 0x0220
+/** Offset 0x01EC
**/
- uint8_t UnusedUpdSpace9[20];
-/** Offset 0x0234
+ uint8_t UnusedUpdSpace4[12];
+/** Offset 0x01F8
**/
- uint8_t ReservedSiliconInitUpd[292];
-} __attribute__((packed));
-
-#define FSP_UPD_SIGNATURE 0x2444505554584224 /* '$BXTUPD$' */
-#define FSP_TEMP_RAM_INIT_UPD_SIGNATURE 0x24445055504D5424 /* '$TMPUPD$' */
-#define FSP_MEMORY_INIT_UPD_SIGNATURE 0x244450554D454D24 /* '$MEMUPD$' */
-#define FSP_SILICON_INIT_UPD_SIGNATURE 0x244450555F495324 /* '$SI_UPD$' */
-
-struct UPD_DATA_REGION {
-/** Offset 0x0000
-**/
- uint64_t Signature;
-/** Offset 0x0008
-**/
- uint8_t Revision;
-/** Offset 0x0009
-**/
- uint8_t ReservedUpd0[7];
-/** Offset 0x0010
-**/
- uint32_t TempRamInitUpdOffset;
-/** Offset 0x0014
-**/
- uint32_t MemoryInitUpdOffset;
-/** Offset 0x0018
-**/
- uint32_t SiliconInitUpdOffset;
-/** Offset 0x001C
-**/
- uint32_t ReservedUpd1;
-/** Offset 0x0020
-**/
- struct TEMP_RAM_INIT_UPD TempRamInitUpd;
-/** Offset 0x0080
-**/
- struct MEMORY_INIT_UPD MemoryInitUpd;
-/** Offset 0x0200
-**/
- struct SILICON_INIT_UPD SiliconInitUpd;
-/** Offset 0x0358
-**/
- uint8_t UnusedUpdSpace10[166];
-/** Offset 0x03FE
-**/
- uint16_t RegionTerminator;
+ uint32_t ReservedSiliconInitUpd;
} __attribute__((packed));
#define FSP_IMAGE_ID 0x2450534654584224 /* '$BXTFSP$' */
-#define FSP_IMAGE_REV 0x01010000
-
-struct VPD_DATA_REGION {
-/** Offset 0x0000
-**/
- uint64_t PcdVpdRegionSign;
-/** Offset 0x0008
- PcdImageRevision
-**/
- uint32_t PcdImageRevision;
-/** Offset 0x000C
-**/
- uint32_t PcdUpdRegionOffset;
-/** Offset 0x0010
-**/
- uint32_t PcdUpdRegionSize;
-/** Offset 0x0014
-**/
- uint64_t UnusedVpdSpace0;
-/** Offset 0x001C
-**/
- uint32_t PcdVpdReserved;
-} __attribute__((packed));
+#define FSP_IMAGE_REV 0x00060000
#endif
diff --git a/src/drivers/intel/fsp2_0/memory_init.c b/src/drivers/intel/fsp2_0/memory_init.c
index 92c30b4..4ac720d 100644
--- a/src/drivers/intel/fsp2_0/memory_init.c
+++ b/src/drivers/intel/fsp2_0/memory_init.c
@@ -41,7 +41,6 @@ typedef asmlinkage enum fsp_status (*fsp_memory_init_fn)
static void fill_console_params(struct MEMORY_INIT_UPD *memupd)
{
- /* TODO: Check that FSP actually respects these flags */
if (IS_ENABLED(CONFIG_CONSOLE_SERIAL)) {
memupd->SerialDebugPortDevice = CONFIG_UART_FOR_CONSOLE;
memupd->SerialDebugPortType = 2;
@@ -65,12 +64,11 @@ static enum fsp_status do_fsp_memory_init(void **hob_list_ptr,
fsp_memory_init_fn fsp_raminit;
struct fsp_memory_init_params raminit_params;
struct fsp_init_rt_common_buffer rt_buffer;
- struct MEMORY_INIT_UPD raminit_upd;
- struct UPD_DATA_REGION *upd_region;
+ struct MEMORY_INIT_UPD raminit_upd, *upd_region;
post_code(0x34);
upd_region = (void*)(hdr->cfg_region_offset + hdr->image_base);
- memcpy(&raminit_upd, upd_region, sizeof(raminit_upd));
+ raminit_upd = *upd_region;
/* Zero fill RT Buffer data and start populating fields. */
memset(&rt_buffer, 0, sizeof(rt_buffer));
diff --git a/src/drivers/intel/fsp2_0/silicon_init.c b/src/drivers/intel/fsp2_0/silicon_init.c
index a6011c9..d600635 100644
--- a/src/drivers/intel/fsp2_0/silicon_init.c
+++ b/src/drivers/intel/fsp2_0/silicon_init.c
@@ -22,15 +22,14 @@ typedef asmlinkage enum fsp_status (*fsp_silicon_init_fn)
static enum fsp_status do_silicon_init(struct fsp_header *hdr)
{
- struct SILICON_INIT_UPD silicon_upd;
+ struct SILICON_INIT_UPD silicon_upd, *upd_region;
fsp_silicon_init_fn silicon_init;
- void *upd_region;
enum fsp_status status;
upd_region = (void*)(hdr->cfg_region_offset + hdr->image_base);
/* populate upd with defaults */
- memcpy(&silicon_upd, upd_region, sizeof(silicon_upd));
+ silicon_upd = *upd_region;
silicon_init = (void *)(hdr->image_base + hdr->silicon_init_entry_offset);
More information about the coreboot-gerrit
mailing list