[coreboot-gerrit] New patch to review for coreboot: cbfstool: provide buffer_offset()

Aaron Durbin (adurbin@chromium.org) gerrit at coreboot.org
Tue Jan 26 16:05:04 CET 2016


Aaron Durbin (adurbin at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13468

-gerrit

commit 756edbbce03212f5c8545e65a65981d2ba29c92a
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Tue Jan 26 09:01:14 2016 -0600

    cbfstool: provide buffer_offset()
    
    Instead of people open coding the offset field access within a
    struct buffer provide buffer_offset() so that the implementation
    can change if needed without high touch in the code base.
    
    Change-Id: I751c7145687a8529ab549d87e412b7f2d1fb90ed
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
---
 util/cbfstool/common.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/util/cbfstool/common.h b/util/cbfstool/common.h
index 561a17a..42ae1e2 100644
--- a/util/cbfstool/common.h
+++ b/util/cbfstool/common.h
@@ -62,6 +62,11 @@ static inline size_t buffer_size(const struct buffer *b)
 	return b->size;
 }
 
+static inline size_t buffer_offset(const struct buffer *b)
+{
+	return b->offset;
+}
+
 /*
  * Shrink a buffer toward the beginning of its previous space.
  * Afterward, buffer_delete() remains the means of cleaning it up. */
@@ -125,7 +130,7 @@ static inline void *buffer_get_original_backing(const struct buffer *b)
 {
 	if (!b)
 		return NULL;
-	return b->data - b->offset;
+	return buffer_get(b) - buffer_offset(b);
 }
 
 /* Creates an empty memory buffer with given size.



More information about the coreboot-gerrit mailing list