[coreboot-gerrit] New patch to review for coreboot: mb/gigabyte/ga-g41m-es2l: Remove copy-pasted cstates

Damien Zammit (damien@zamaudio.com) gerrit at coreboot.org
Tue Jan 26 07:27:27 CET 2016


Damien Zammit (damien at zamaudio.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13465

-gerrit

commit bfd6f2e7820f7ca09f4771e1b49130eb4beb976c
Author: Damien Zammit <damien at zamaudio.com>
Date:   Tue Jan 26 17:17:27 2016 +1100

    mb/gigabyte/ga-g41m-es2l: Remove copy-pasted cstates
    
    Change-Id: I5b6edbd97d4e6ed8b03f2f319a338022647e26ea
    Signed-off-by: Damien Zammit <damien at zamaudio.com>
---
 src/mainboard/gigabyte/ga-g41m-es2l/cstates.c     | 13 +------------
 src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb |  3 ---
 2 files changed, 1 insertion(+), 15 deletions(-)

diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/cstates.c b/src/mainboard/gigabyte/ga-g41m-es2l/cstates.c
index dbac2ed..4d9f4ab 100644
--- a/src/mainboard/gigabyte/ga-g41m-es2l/cstates.c
+++ b/src/mainboard/gigabyte/ga-g41m-es2l/cstates.c
@@ -17,18 +17,7 @@
 #include <device/device.h>
 #include <southbridge/intel/i82801gx/i82801gx.h>
 
-static acpi_cstate_t cst_entries[] = {
-	{
-		/* acpi C1 / cpu C1 */
-		1, 0x01, 1000,
-		{ ACPI_ADDRESS_SPACE_FIXED, 1, 2, { 1 }, 0, 0 }
-	},
-	{
-		/* acpi C2 / cpu C2 */
-		2, 0x01,  500,
-		{ ACPI_ADDRESS_SPACE_FIXED, 1, 2, { 1 }, 0x10, 0 }
-	},
-};
+static acpi_cstate_t cst_entries[] = {};
 
 int get_cst_entries(acpi_cstate_t **entries)
 {
diff --git a/src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb b/src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb
index e6b691c..3965538 100644
--- a/src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb
+++ b/src/mainboard/gigabyte/ga-g41m-es2l/devicetree.cb
@@ -21,9 +21,6 @@ chip northbridge/intel/x4x		# Northbridge
     end
     chip cpu/intel/model_1067x		# CPU
       device lapic 0xACAC off end
-      register "slfm" = "1"
-      register "c5" = "1"
-      register "c6" = "1"
     end
   end
   device domain 0 on		# PCI domain



More information about the coreboot-gerrit mailing list