[coreboot-gerrit] New patch to review for coreboot: FSP 1.1: Enable builds without MRC cache

Leroy P Leahy (leroy.p.leahy@intel.com) gerrit at coreboot.org
Tue Jan 26 01:34:36 CET 2016


Leroy P Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13437

-gerrit

commit c63fc968759931fd9d1e3c1000df22cd7a277ea6
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Tue Jan 5 16:34:58 2016 -0800

    FSP 1.1: Enable builds without MRC cache
    
    Properly use the CONFIG_CACHE_MRC_SETTINGS value to determine when to
    cache the MRC settings.
    
    BRANCH=none
    BUG=None
    TEST=Build and run on Galileo
    
    Change-Id: Ibc76b20b9603b1e436a68b71d44ca1ca04db7168
    Signed-off-by: Lee Leahy <leroy.p.leahy at intel.com>
---
 src/drivers/intel/fsp1_1/romstage.c | 25 +++++++++++++------------
 1 file changed, 13 insertions(+), 12 deletions(-)

diff --git a/src/drivers/intel/fsp1_1/romstage.c b/src/drivers/intel/fsp1_1/romstage.c
index 6d51be9..3b3b5ac 100644
--- a/src/drivers/intel/fsp1_1/romstage.c
+++ b/src/drivers/intel/fsp1_1/romstage.c
@@ -126,8 +126,9 @@ void romstage_common(struct romstage_params *params)
 			/* Recovery mode does not use MRC cache */
 			printk(BIOS_DEBUG,
 			       "Recovery mode: not using MRC cache.\n");
-		} else if (!mrc_cache_get_current_with_version(&cache,
-							params->fsp_version)) {
+		} else if (IS_ENABLED(CONFIG_CACHE_MRC_SETTINGS)
+			&& (!mrc_cache_get_current_with_version(&cache,
+							params->fsp_version))) {
 			/* MRC cache found */
 			params->pei_data->saved_data_size = cache->size;
 			params->pei_data->saved_data = &cache->data[0];
@@ -148,16 +149,16 @@ void romstage_common(struct romstage_params *params)
 	timestamp_add_now(TS_AFTER_INITRAM);
 
 	/* Save MRC output */
-	printk(BIOS_DEBUG, "MRC data at %p %d bytes\n", pei_data->data_to_save,
-	       pei_data->data_to_save_size);
-	if (params->pei_data->boot_mode != SLEEP_STATE_S3) {
-		if (params->pei_data->data_to_save_size != 0 &&
-		    params->pei_data->data_to_save != NULL) {
-			mrc_cache_stash_data_with_version(
-				params->pei_data->data_to_save,
-				params->pei_data->data_to_save_size,
-				params->fsp_version);
-		}
+	if (IS_ENABLED(CONFIG_CACHE_MRC_SETTINGS)) {
+		printk(BIOS_DEBUG, "MRC data at %p %d bytes\n",
+			pei_data->data_to_save, pei_data->data_to_save_size);
+		if ((params->pei_data->boot_mode != SLEEP_STATE_S3)
+			&& (params->pei_data->data_to_save_size != 0)
+			&& (params->pei_data->data_to_save != NULL))
+				mrc_cache_stash_data_with_version(
+					params->pei_data->data_to_save,
+					params->pei_data->data_to_save_size,
+					params->fsp_version);
 	}
 
 	/* Save DIMM information */



More information about the coreboot-gerrit mailing list