[coreboot-gerrit] Patch set updated for coreboot: drivers/intel/fsp2_0/Kconfig: Use "depends on" instead of "if"

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Mon Jan 25 18:04:10 CET 2016


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13383

-gerrit

commit e89f362793b35525ebbbae66ba84825bc3f98cc5
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date:   Tue Dec 15 14:55:29 2015 -0800

    drivers/intel/fsp2_0/Kconfig: Use "depends on" instead of "if"
    
    When FSP_M_FILE and FSP_S_FILE are depended with "depends on" instead
    of being stuffed in an "if" block, they appear indented under the
    ADD_FSP_BINARIES option, at least with xconfig. This makes
    configuration easier to understand.
    
    Change-Id: Ib28261a84bc5f0184ad36dfef5a19f6c844acf91
    Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
 src/drivers/intel/fsp2_0/Kconfig | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/drivers/intel/fsp2_0/Kconfig b/src/drivers/intel/fsp2_0/Kconfig
index 0103921..3c81eb9 100644
--- a/src/drivers/intel/fsp2_0/Kconfig
+++ b/src/drivers/intel/fsp2_0/Kconfig
@@ -13,19 +13,18 @@ config ADD_FSP_BINARIES
 	  Add the FSP-M and FSP-S binaries to CBFS. Note that coreboot does not
 	  use the FSP-T binary, so that will not be included.
 
-if ADD_FSP_BINARIES
-
 config FSP_M_FILE
 	string "Intel FSP-M (memory init) binary path and filename"
+	depends on ADD_FSP_BINARIES
 	help
 	  The path and filename of the Intel FSP-M binary for this platform.
 
 config FSP_S_FILE
 	string "Intel FSP-S (silicon init) binary path and filename"
+	depends on ADD_FSP_BINARIES
 	help
 	  The path and filename of the Intel FSP-S binary for this platform.
 
-endif # ADD_FSP_BINARIES
 
 config FIT_CAR_ADDR
 	hex



More information about the coreboot-gerrit mailing list