[coreboot-gerrit] Patch set updated for coreboot: arch/x86/Makefile.inc: Re-enable -Wa, --divide assembler flag

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Mon Jan 25 18:03:09 CET 2016


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13299

-gerrit

commit 3bffb77ef8c5f5138e09bd3229b2cca2ddb39e51
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date:   Tue Oct 6 14:41:20 2015 -0700

    arch/x86/Makefile.inc: Re-enable -Wa,--divide assembler flag
    
    In the follow-on patches, we use constant division to calculate the
    number of elements in an assembly structure. Since the size of one
    element is not a power of two for all structures, we can't bit shift.
    This allows us to do the computation at assembly time rather than
    runtime.
    
    Change-Id: Ic5693f39dee8daf759bfc16c79ac3c7ddb4de465
    Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
 src/arch/x86/Makefile.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index 99ce184..86290ab 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -102,6 +102,8 @@ endef
 
 ifeq ($(CONFIG_ARCH_BOOTBLOCK_X86_32)$(CONFIG_ARCH_BOOTBLOCK_X86_64),y)
 
+CFLAGS_bootblock+=-Wa,--divide
+
 bootblock-y += boot.c
 bootblock-y += memcpy.c
 bootblock-y += memset.c



More information about the coreboot-gerrit mailing list