[coreboot-gerrit] Patch set updated for coreboot: soc/apollolake/acpi: Fill ACPI HPET table

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Mon Jan 25 06:40:06 CET 2016


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13374

-gerrit

commit 57289aacd68ffe8bd6427bed24b5779be3f03fe2
Author: Zhao, Lijian <lijian.zhao at intel.com>
Date:   Tue Dec 1 09:14:20 2015 -0800

    soc/apollolake/acpi: Fill ACPI HPET table
    
    HPET table is required to report integrated HPET timer to kernel.Without
    HPET table insert,current kernel will panic in Timer driver.
    
    Change-Id: I7368bc29f4e03d5882dcfc4a770fa7bfbc6c26a0
    Signed-off-by: Zhao, Lijian <lijian.zhao at intel.com>
---
 src/soc/intel/apollolake/acpi.c             | 7 +++++++
 src/soc/intel/apollolake/include/soc/acpi.h | 3 +++
 src/soc/intel/apollolake/lpc.c              | 2 ++
 3 files changed, 12 insertions(+)

diff --git a/src/soc/intel/apollolake/acpi.c b/src/soc/intel/apollolake/acpi.c
index 0161294..16acd0f 100644
--- a/src/soc/intel/apollolake/acpi.c
+++ b/src/soc/intel/apollolake/acpi.c
@@ -111,3 +111,10 @@ void soc_fill_common_fadt(acpi_fadt_t * fadt)
 
 	fadt->x_gpe1_blk.space_id = 1;
 }
+
+unsigned long southbridge_write_acpi_tables(device_t device,
+					    unsigned long current,
+					    struct acpi_rsdp *rsdp)
+{
+	return acpi_write_hpet(device, current, rsdp);
+}
diff --git a/src/soc/intel/apollolake/include/soc/acpi.h b/src/soc/intel/apollolake/include/soc/acpi.h
index 7e112d7..bb655eb 100644
--- a/src/soc/intel/apollolake/include/soc/acpi.h
+++ b/src/soc/intel/apollolake/include/soc/acpi.h
@@ -18,4 +18,7 @@
 /* Zero value won't be programmed again in FADT table. */
 void soc_fill_common_fadt(acpi_fadt_t * fadt);
 
+unsigned long southbridge_write_acpi_tables(device_t device,
+                unsigned long current, struct acpi_rsdp *rsdp);
+
 #endif				/* _SOC_APOLLOLAKE_ACPI_H_ */
diff --git a/src/soc/intel/apollolake/lpc.c b/src/soc/intel/apollolake/lpc.c
index 8f0d2ad..6d2e8ca 100644
--- a/src/soc/intel/apollolake/lpc.c
+++ b/src/soc/intel/apollolake/lpc.c
@@ -13,6 +13,7 @@
 #include <device/device.h>
 #include <device/pci.h>
 #include <device/pci_ids.h>
+#include <soc/acpi.h>
 
 static void soc_lpc_add_io_resources(device_t dev)
 {
@@ -38,6 +39,7 @@ static struct device_operations device_ops = {
 	.read_resources = &soc_lpc_read_resources,
 	.set_resources = &pci_dev_set_resources,
 	.enable_resources = &pci_dev_enable_resources,
+	.write_acpi_tables = southbridge_write_acpi_tables,
 };
 
 static const unsigned short pci_device_ids[] = {



More information about the coreboot-gerrit mailing list