[coreboot-gerrit] Patch set updated for coreboot: soc/intel/apollolake: Do not setup ACPI SMI_CMD

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Mon Jan 25 06:41:33 CET 2016


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13389

-gerrit

commit 3562142e797a1830013c2762bab52074a4fc534c
Author: Zhao, Lijian <lijian.zhao at intel.com>
Date:   Mon Jan 4 16:34:07 2016 -0800

    soc/intel/apollolake: Do not setup ACPI SMI_CMD
    
    Current coreboot do not have the smm setup, also no smi handler yet.So we
    should not report the SMI CMD port to ACPI FADT table, also the ACPI enable
    and ACPI disable command should be zero as well.
    
    Change-Id: I1d03082359191eee7e13bfea5a98c65e0722dfb2
    Signed-off-by: Zhao, Lijian <lijian.zhao at intel.com>
---
 src/soc/intel/apollolake/acpi.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/soc/intel/apollolake/acpi.c b/src/soc/intel/apollolake/acpi.c
index 9939408..3b622b8 100644
--- a/src/soc/intel/apollolake/acpi.c
+++ b/src/soc/intel/apollolake/acpi.c
@@ -63,9 +63,7 @@ void soc_fill_common_fadt(acpi_fadt_t * fadt)
 	const uint16_t pmbase = ACPI_PMIO_BASE;
 
 	fadt->sci_int = acpi_sci_irq();
-	fadt->smi_cmd = APM_CNT;
-	fadt->acpi_enable = APM_CNT_ACPI_ENABLE;
-	fadt->acpi_disable = APM_CNT_ACPI_DISABLE;
+	fadt->smi_cmd = 0; /* No Smi Handler as SMI_CMD is 0*/
 
 	fadt->pm1a_evt_blk = pmbase + PM1_STS;
 	fadt->pm1a_cnt_blk = pmbase + PM1_CNT;



More information about the coreboot-gerrit mailing list