[coreboot-gerrit] Patch set updated for coreboot: drivers/intel/fsp2_0: Add infrastructure to parse resource HOBs
Alexandru Gagniuc (mr.nuke.me@gmail.com)
gerrit at coreboot.org
Mon Jan 25 06:39:58 CET 2016
Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13350
-gerrit
commit cae9194360a36f8b8d8f96b80243a4f544f8897f
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date: Mon Nov 9 17:07:18 2015 -0800
drivers/intel/fsp2_0: Add infrastructure to parse resource HOBs
This adds the minimal infrastructure to allow printing reource HOBs
returned by FSP memory_init, and to allow locating the FSP reserved
memory area.
Change-Id: Ie79441aacdb808200921817f537bf01e0456b72c
Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
src/drivers/intel/fsp2_0/Makefile.inc | 2 +
src/drivers/intel/fsp2_0/hand_off_block.c | 230 ++++++++++++++++++++++++++++
src/drivers/intel/fsp2_0/include/fsp/util.h | 14 ++
3 files changed, 246 insertions(+)
diff --git a/src/drivers/intel/fsp2_0/Makefile.inc b/src/drivers/intel/fsp2_0/Makefile.inc
index ef0cae8..e7081a7 100644
--- a/src/drivers/intel/fsp2_0/Makefile.inc
+++ b/src/drivers/intel/fsp2_0/Makefile.inc
@@ -1,3 +1,5 @@
+
+romstage-y += hand_off_block.c
romstage-y += util.c
romstage-y += memory_init.c
diff --git a/src/drivers/intel/fsp2_0/hand_off_block.c b/src/drivers/intel/fsp2_0/hand_off_block.c
new file mode 100644
index 0000000..8529b58
--- /dev/null
+++ b/src/drivers/intel/fsp2_0/hand_off_block.c
@@ -0,0 +1,230 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2015 Intel Corp.
+ * (Written by Alexandru Gagniuc <alexandrux.gagniuc at intel.com> for Intel Corp.)
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include <arch/io.h>
+#include <cbmem.h>
+#include <commonlib/helpers.h>
+#include <console/console.h>
+#include <fsp/util.h>
+#include <inttypes.h>
+#include <lib.h>
+#include <string.h>
+
+void hoboparse (const void *hob);
+
+#define HOB_HEADER_LEN 8
+
+struct hob_header {
+ uint16_t type;
+ uint16_t length;
+} __attribute__((packed));
+
+struct hob_resource {
+ uint8_t owner_guid[16];
+ uint32_t type;
+ uint32_t attribute_type;
+ uint64_t addr;
+ uint64_t length;
+} __attribute__((packed));
+
+enum resource_type {
+ EFI_RESOURCE_SYSTEM_MEMORY = 0,
+ EFI_RESOURCE_MEMORY_MAPPED_IO = 1,
+ EFI_RESOURCE_IO = 2,
+ EFI_RESOURCE_FIRMWARE_DEVICE = 3,
+ EFI_RESOURCE_MEMORY_MAPPED_IO_PORT = 4,
+ EFI_RESOURCE_MEMORY_RESERVED = 5,
+ EFI_RESOURCE_IO_RESERVED = 6,
+ EFI_RESOURCE_MAX_MEMORY_TYPE = 7,
+};
+
+static const char *resource_names[] = {
+ [EFI_RESOURCE_SYSTEM_MEMORY] = "SYSTEM_MEMORY",
+ [EFI_RESOURCE_MEMORY_MAPPED_IO] = "MMIO",
+ [EFI_RESOURCE_IO] = "IO",
+ [EFI_RESOURCE_FIRMWARE_DEVICE] = "FIRMWARE_DEVICE",
+ [EFI_RESOURCE_MEMORY_MAPPED_IO_PORT] = "MMIO_PORT",
+ [EFI_RESOURCE_MEMORY_RESERVED] = "MEMORY_RESERVED",
+ [EFI_RESOURCE_IO_RESERVED] = "IO_RESERVED",
+};
+
+enum hob_type {
+ HOB_TYPE_HANDOFF = 0x0001,
+ HOB_TYPE_MEMORY_ALLOCATION = 0x0002,
+ HOB_TYPE_RESOURCE_DESCRIPTOR = 0x0003,
+ HOB_TYPE_GUID_EXTENSION = 0x0004,
+ HOB_TYPE_FV = 0x0005,
+ HOB_TYPE_CPU = 0x0006,
+ HOB_TYPE_MEMORY_POOL = 0x0007,
+ HOB_TYPE_FV2 = 0x0009,
+ HOB_TYPE_LOAD_PEIM_UNUSED = 0x000A,
+ HOB_TYPE_UCAPSULE = 0x000B,
+ HOB_TYPE_UNUSED = 0xFFFE,
+ HOB_TYPE_END_OF_HOB_LIST = 0xFFFF,
+};
+
+/* UUIDs (GUIDs) in little-endian, so they can be used with memcmp() */
+static const uint8_t uuid_owner_fsp[16] = {
+ 0x59, 0x97, 0xa7, 0x69, 0x73, 0x13, 0x67, 0x43,
+ 0xa6, 0xc4, 0xc7, 0xf5, 0x9e, 0xfd, 0x98, 0x6e,
+};
+
+static const uint8_t empty_uuid[16] = {
+ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0
+};
+
+static const char *resource_name(enum resource_type type)
+{
+ if (type >= ARRAY_SIZE(resource_names))
+ return "UNKNOWN";
+ return resource_names[type];
+}
+
+/*
+ * Utilities for walking HOBs
+ */
+
+static bool uuid_compare(const uint8_t uuid1[16], const uint8_t uuid2[16])
+{
+ return !memcmp(uuid1, uuid2, 16);
+}
+
+static const struct hob_header *next_hob(const struct hob_header *parent)
+{
+ union {
+ const struct hob_header *hob;
+ uintptr_t addr;
+ } hob_walker;
+
+ hob_walker.hob = parent;
+ hob_walker.addr += parent->length;
+ return hob_walker.hob;
+}
+
+static const void *hob_header_to_struct(const struct hob_header *hob)
+{
+ union {
+ const struct hob_header *hob_hdr;
+ const void *hob_descr;
+ uintptr_t addr;
+ } hob_walker;
+
+ hob_walker.hob_hdr = hob;
+ hob_walker.addr += HOB_HEADER_LEN;
+ return hob_walker.hob_descr;
+}
+
+static const
+struct hob_resource *hob_header_to_resource(const struct hob_header *hob)
+{
+ return hob_header_to_struct(hob);
+}
+
+/*
+ * Utilities for locating and identifying HOBs
+ */
+
+void fsp_save_hob_list(void *hob_list_ptr)
+{
+ void **cbmem_loc;
+ cbmem_loc = cbmem_add(CBMEM_ID_FSP_RUNTIME, sizeof(*hob_list_ptr));
+ *cbmem_loc = hob_list_ptr;
+}
+
+const void *fsp_get_hob_list(void)
+{
+ void **list_loc = cbmem_find(CBMEM_ID_FSP_RUNTIME);
+
+ return (list_loc) ? (*list_loc) : NULL;
+}
+
+static const
+struct hob_resource *find_resource_hob_by_uuid(const struct hob_header *hob,
+ const uint8_t uuid[16])
+{
+ const struct hob_resource *res;
+
+ for ( ; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = next_hob(hob)) {
+
+ if (hob->type != HOB_TYPE_RESOURCE_DESCRIPTOR)
+ continue;
+
+ res = hob_header_to_resource(hob);
+ if (uuid_compare(res->owner_guid, uuid))
+ return res;
+ }
+ return NULL;
+}
+
+void fsp_find_reserved_memory(struct resource *res, const void *hob_list)
+{
+ const struct hob_resource *fsp_mem;
+
+ res->size = 0;
+ res->align = 0;
+ res->gran = 0;
+ res->next = NULL;
+
+ fsp_mem = find_resource_hob_by_uuid(hob_list, uuid_owner_fsp);
+
+ if (!fsp_mem) {
+ return;
+ }
+
+ res->base = fsp_mem->addr;
+ res->size = fsp_mem->length;
+}
+
+/*
+ * Utilities for printing HOB information
+ */
+
+static void print_guid(const void *base)
+{
+ uint32_t big;
+ uint16_t mid[2];
+
+ const uint8_t *id = base;
+ big = read32(id + 0);
+ mid[0] = read16(id + 4);
+ mid[1] = read16(id + 6);
+
+ printk(BIOS_DEBUG, "%08x-%04x-%04x-%02x%02x%02x%02x%02x%02x%02x%02x\n",
+ big, mid[0], mid[1],
+ id[8], id[9], id[10], id[11], id[12], id[13],id[14], id[15]);
+}
+
+static void print_resource_descriptor(const void *base)
+{
+ const struct hob_resource *res;
+
+ res = hob_header_to_resource(base);
+
+ printk(BIOS_DEBUG, "Resource %s, attribute %x\n",
+ resource_name(res->type), res->attribute_type);
+ printk(BIOS_DEBUG, "\t0x%08llx + 0x%08llx\n", res->addr, res->length);
+ if (!uuid_compare(res->owner_guid, empty_uuid)) {
+ printk(BIOS_DEBUG, "\tOwner GUID: ");
+ print_guid(res->owner_guid);
+ }
+}
+
+
+void fsp_print_memory_resource_hobs(const void *hob_list)
+{
+ const struct hob_header *hob = hob_list;
+
+ for ( ; hob->type != HOB_TYPE_END_OF_HOB_LIST; hob = next_hob(hob)) {
+ if (hob->type == HOB_TYPE_RESOURCE_DESCRIPTOR)
+ print_resource_descriptor(hob);
+ }
+}
diff --git a/src/drivers/intel/fsp2_0/include/fsp/util.h b/src/drivers/intel/fsp2_0/include/fsp/util.h
index abdbcf0..0e3f412 100644
--- a/src/drivers/intel/fsp2_0/include/fsp/util.h
+++ b/src/drivers/intel/fsp2_0/include/fsp/util.h
@@ -14,6 +14,20 @@
#define _FSP2_0_UTIL_H_
#include <fsp/info_header.h>
+#include <device/resource.h>
+
+/*
+ * Hand-off-block handling functions that depend on CBMEM, and thus can only
+ * be used after cbmem_initialize().
+ */
+void fsp_save_hob_list(void *hob_list_ptr);
+const void *fsp_get_hob_list(void);
+/*
+ * Hand-off-block utilities which do not depend on CBMEM, but need to be passed
+ * the HOB list explicitly.
+ */
+void fsp_find_reserved_memory(struct resource *res, const void *hob_list);
+void fsp_print_memory_resource_hobs(const void *hob_list);
/* Load an FSP binary into CBFS, and fill the associated fsp_header struct */
enum cb_err fsp_load_binary(struct fsp_header *hdr, const char *name);
More information about the coreboot-gerrit
mailing list