[coreboot-gerrit] Patch set updated for coreboot: Makefile: Don't copy thin archives around

Nico Huber (nico.h@gmx.de) gerrit at coreboot.org
Mon Jan 25 00:35:24 CET 2016


Nico Huber (nico.h at gmx.de) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13179

-gerrit

commit c897d846078609b57900f5c3b890496480f54cca
Author: Nico Huber <nico.h at gmx.de>
Date:   Sat Jan 23 03:23:23 2016 +0100

    Makefile: Don't copy thin archives around
    
    We can't just copy archives around as they may be thin archives which
    contain relative paths. Using ar to create another thin archive should
    result in the same archive with fixed paths.
    
    Tested by verifying that the resulting coreboot.rom files didn't change
    for all of Jenkins' abuild configurations.
    
    Change-Id: Ic5743da2f4b5eb246fafd02181d66c5d40e7f00c
    Signed-off-by: Nico Huber <nico.h at gmx.de>
---
 Makefile.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Makefile.inc b/Makefile.inc
index 43996d8..441ee88 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -183,8 +183,8 @@ endef
 define generic-objs_a_template_gen
 de$(EMPTY)fine $(1)-objs_a_template
 $$(call src-to-obj,$1,$$(1).a): $$(1).a
-	@printf "    CP         $$$$(subst $$$$(obj)/,,$$$$(@))\n"
-	cp $$$$< $$$$@.tmp
+	@printf "    AR         $$$$(subst $$$$(obj)/,,$$$$(@))\n"
+	$$$$(AR_$(1)) rcsT $$$$@.tmp $$$$<
 	mv $$$$@.tmp $$$$@
 en$(EMPTY)def
 endef



More information about the coreboot-gerrit mailing list