[coreboot-gerrit] New patch to review for coreboot: mainboard/apollolake_rvp: Configure backlight control GPIOs

Andrey Petrov (andrey.petrov@intel.com) gerrit at coreboot.org
Sun Jan 24 03:33:52 CET 2016


Andrey Petrov (andrey.petrov at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13379

-gerrit

commit c6f8faade50b8fed2ab006d7146a0b40812584c0
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date:   Wed Dec 9 16:52:35 2015 -0800

    mainboard/apollolake_rvp: Configure backlight control GPIOs
    
    It is unclear whether FSP expects the backlight control pads to be
    pre-configured, or whether it configures them itself. We explicitly
    configure them for several reasons:
      * document the GPIO configuration of the board
      * to be consistent with other peripherals (eg. UART)
      * future-proof against FSP updates which expect pre-configured pads
    
    Change-Id: Ie4f9be8b35fa1396fdf4fc438a22e1fbc1dac40c
    Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
 src/mainboard/intel/apollolake_rvp/mainboard.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/mainboard/intel/apollolake_rvp/mainboard.c b/src/mainboard/intel/apollolake_rvp/mainboard.c
index 3ed3d8f..e82f4a5 100644
--- a/src/mainboard/intel/apollolake_rvp/mainboard.c
+++ b/src/mainboard/intel/apollolake_rvp/mainboard.c
@@ -17,6 +17,9 @@
 static const struct pad_config aplk_rvp_gpios[] = {
 	PAD_CFG_NF(GPIO_46, NATIVE, DEEP, NF1),	/* UART2 RX*/
 	PAD_CFG_NF(GPIO_47, NATIVE, DEEP, NF1),	/* UART2 TX*/
+	PAD_CFG_NF(GPIO_193, NATIVE, DEEP, NF1),	/* PANEL0_VDDEN */
+	PAD_CFG_NF(GPIO_194, NATIVE, DEEP, NF1),	/* PANEL0_BKLTEN */
+	PAD_CFG_NF(GPIO_195, NATIVE, DEEP, NF1),	/* PANEL0_BKLTCTL */
 };
 
 static void mainboard_enable(struct device *dev)



More information about the coreboot-gerrit mailing list