[coreboot-gerrit] New patch to review for coreboot: intel/apollolake_rvp: Add GPIO configuration for UART2 pads

Andrey Petrov (andrey.petrov@intel.com) gerrit at coreboot.org
Sun Jan 24 03:33:44 CET 2016


Andrey Petrov (andrey.petrov at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13369

-gerrit

commit 187d2f77c99a8235def3eaa420be4d9970bc50cd
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date:   Wed Nov 25 14:59:37 2015 -0800

    intel/apollolake_rvp: Add GPIO configuration for UART2 pads
    
    UART2 is the main debugging interface. Older FSP versions configured
    the TX and RX pads, but that is no longer the case. We now need to
    configure the pads in coreboot.
    This fixes an issue where serial input would no longer work with newer
    FSP versions.
    
    Change-Id: I9c2354720bf428439b7262b32ce1ea5c9eddbdfb
    Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
 src/mainboard/intel/apollolake_rvp/Makefile.inc |  2 +-
 src/mainboard/intel/apollolake_rvp/mainboard.c  | 29 +++++++++++++++++++++++++
 2 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/intel/apollolake_rvp/Makefile.inc b/src/mainboard/intel/apollolake_rvp/Makefile.inc
index a48936e..f3c87b2 100755
--- a/src/mainboard/intel/apollolake_rvp/Makefile.inc
+++ b/src/mainboard/intel/apollolake_rvp/Makefile.inc
@@ -1 +1 @@
-# Nothing yet here
+ramstage-y += mainboard.c
diff --git a/src/mainboard/intel/apollolake_rvp/mainboard.c b/src/mainboard/intel/apollolake_rvp/mainboard.c
new file mode 100644
index 0000000..3ed3d8f
--- /dev/null
+++ b/src/mainboard/intel/apollolake_rvp/mainboard.c
@@ -0,0 +1,29 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright (C) 2015 Intel Corp.
+ * (Alexandru Gagniuc <alexandrux.gagniuc at intel.com> for Intel Corp.)
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ */
+
+#include <device/device.h>
+#include <soc/gpio.h>
+
+/* TODO: Move GPIO config to its own file once we get more GPIOs in the list */
+static const struct pad_config aplk_rvp_gpios[] = {
+	PAD_CFG_NF(GPIO_46, NATIVE, DEEP, NF1),	/* UART2 RX*/
+	PAD_CFG_NF(GPIO_47, NATIVE, DEEP, NF1),	/* UART2 TX*/
+};
+
+static void mainboard_enable(struct device *dev)
+{
+	gpio_configure_pads(aplk_rvp_gpios, ARRAY_SIZE(aplk_rvp_gpios));
+}
+
+struct chip_operations mainboard_ops = {
+	.enable_dev = mainboard_enable,
+};



More information about the coreboot-gerrit mailing list