[coreboot-gerrit] New patch to review for coreboot: arch/x86: Drop arch/pciconf.h

Stefan Reinauer (stefan.reinauer@coreboot.org) gerrit at coreboot.org
Sat Jan 23 01:17:06 CET 2016


Stefan Reinauer (stefan.reinauer at coreboot.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13177

-gerrit

commit 3dcbe8d1c853ebacfc0d5f96fa7b3795c6d9962a
Author: Stefan Reinauer <stefan.reinauer at coreboot.org>
Date:   Sat Jan 23 01:15:42 2016 +0100

    arch/x86: Drop arch/pciconf.h
    
    It's unused, so get rid of it.
    
    Change-Id: I28c6dc0208686edc3aabaf624773ea70350c1c8f
    Signed-off-by: Stefan Reinauer <stefan.reinauer at coreboot.org>
---
 src/arch/x86/include/arch/pciconf.h | 27 ---------------------------
 src/arch/x86/pci_ops_conf1.c        |  1 -
 src/arch/x86/pci_ops_mmconf.c       |  1 -
 src/device/pci_ops.c                |  1 -
 4 files changed, 30 deletions(-)

diff --git a/src/arch/x86/include/arch/pciconf.h b/src/arch/x86/include/arch/pciconf.h
deleted file mode 100644
index 2fd4365..0000000
--- a/src/arch/x86/include/arch/pciconf.h
+++ /dev/null
@@ -1,27 +0,0 @@
-/*
- * This file is part of the coreboot project.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; version 2 of the License.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU General Public License for more details.
- */
-
-#ifndef PCI_CONF_REG_INDEX
-
-// These are defined in the PCI spec, and hence are theoretically
-// inclusive of ANYTHING that uses a PCI bus.
-#define	PCI_CONF_REG_INDEX	0xcf8
-#define	PCI_CONF_REG_DATA	0xcfc
-
-#if !CONFIG_PCI_IO_CFG_EXT
-#define CONFIG_ADDR(bus,devfn,where) (((bus) << 16) | ((devfn) << 8) | (where))
-#else
-#define CONFIG_ADDR(bus,devfn,where) (((bus) << 16) | ((devfn) << 8) | (where & 0xff) | ((where & 0xf00)<<16) )
-#endif
-
-#endif
diff --git a/src/arch/x86/pci_ops_conf1.c b/src/arch/x86/pci_ops_conf1.c
index 2b90a16..2310810 100644
--- a/src/arch/x86/pci_ops_conf1.c
+++ b/src/arch/x86/pci_ops_conf1.c
@@ -13,7 +13,6 @@
 
 #include <console/console.h>
 #include <arch/io.h>
-#include <arch/pciconf.h>
 #include <device/pci.h>
 #include <device/pci_ids.h>
 #include <device/pci_ops.h>
diff --git a/src/arch/x86/pci_ops_mmconf.c b/src/arch/x86/pci_ops_mmconf.c
index 500a37d..989c580 100644
--- a/src/arch/x86/pci_ops_mmconf.c
+++ b/src/arch/x86/pci_ops_mmconf.c
@@ -13,7 +13,6 @@
 
 #include <console/console.h>
 #include <arch/io.h>
-#include <arch/pciconf.h>
 #include <device/pci.h>
 #include <device/pci_ids.h>
 #include <device/pci_ops.h>
diff --git a/src/device/pci_ops.c b/src/device/pci_ops.c
index fed17fc..ab72405 100644
--- a/src/device/pci_ops.c
+++ b/src/device/pci_ops.c
@@ -16,7 +16,6 @@
  */
 
 #include <console/console.h>
-#include <arch/pciconf.h>
 #include <device/pci.h>
 #include <device/pci_ids.h>
 #include <device/pci_ops.h>



More information about the coreboot-gerrit mailing list