[coreboot-gerrit] New patch to review for coreboot: northbridge/amd/amdmct/mct_ddr3: Enable fast refresh on ETR devices

Timothy Pearson (tpearson@raptorengineeringinc.com) gerrit at coreboot.org
Sat Jan 23 00:33:23 CET 2016


Timothy Pearson (tpearson at raptorengineeringinc.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13144

-gerrit

commit 9056a9a994ed50aacd3dfc12f604777483db1299
Author: Timothy Pearson <tpearson at raptorengineeringinc.com>
Date:   Tue Nov 24 14:11:50 2015 -0600

    northbridge/amd/amdmct/mct_ddr3: Enable fast refresh on ETR devices
    
    When an Extended Temperature Range DIMM is installed on a channel
    the refresh rate should be increased per the BKDG recommendations
    to allow correct operation at higher temperature ranges.
    
    Set fast refresh on a channel if an ETR DIMM is installed on that
    channel.
    
    Change-Id: I7a085d34efc78f3f0794a5cb33b88f27a5e6d54e
    Signed-off-by: Timothy Pearson <tpearson at raptorengineeringinc.com>
---
 src/northbridge/amd/amdmct/mct_ddr3/mct_d.c | 12 +++++++++++-
 src/northbridge/amd/amdmct/mct_ddr3/mct_d.h |  5 +++--
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
index ac5220e..beb71f9 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.c
@@ -3993,6 +3993,7 @@ static void SPD2ndTiming(struct MCTStatStruc *pMCTstat,
 	u32 DramTimingLo, DramTimingHi;
 	u8 tCK16x;
 	u16 Twtr;
+	uint8_t Etr[2];
 	u8 LDIMM;
 	u8 MTB16x;
 	u8 byte;
@@ -4011,6 +4012,8 @@ static void SPD2ndTiming(struct MCTStatStruc *pMCTstat,
 	Trc = 0;
 	Twr = 0;
 	Twtr = 0;
+	for (i=0; i < 2; i++)
+		Etr[i] = 0;
 	for (i=0; i < 4; i++)
 		Trfc[i] = 0;
 	Tfaw = 0;
@@ -4077,6 +4080,10 @@ static void SPD2ndTiming(struct MCTStatStruc *pMCTstat,
 			val *= MTB16x;
 			if (Tfaw < val)
 				Tfaw = val;
+
+			/* Determine if the DIMMs on this channel support 95°C ETR */
+			if (pDCTstat->spd_data.spd_bytes[dct + i][SPD_Thermal] & 0x1)
+				Etr[dct] = 1;
 		}	/* Dimm Present */
 	}
 
@@ -4248,7 +4255,10 @@ static void SPD2ndTiming(struct MCTStatStruc *pMCTstat,
 		dev = pDCTstat->dev_dct;
 
 		dword = Get_NB32_DCT(dev, dct, 0x8c);				/* DRAM Timing High */
-		val = 2;							/* Tref = 7.8us */
+		if (Etr[dct])
+			val = 3;						/* Tref = 3.9us */
+		else
+			val = 2;						/* Tref = 7.8us */
 		dword &= ~(0x3 << 16);
 		dword |= (val & 0x3) << 16;
 		Set_NB32_DCT(dev, dct, 0x8c, dword);				/* DRAM Timing High */
diff --git a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.h b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.h
index 5f72ff3..e7361ac 100644
--- a/src/northbridge/amd/amdmct/mct_ddr3/mct_d.h
+++ b/src/northbridge/amd/amdmct/mct_ddr3/mct_d.h
@@ -217,8 +217,8 @@
 #define SPD_CASHigh		15
 #define SPD_tAAmin		16
 
-#define SPD_DEVATTRIB	22
-#define SPD_EDCTYPE	11
+#define SPD_DEVATTRIB		22
+#define SPD_EDCTYPE		11
 	#define JED_ADRCPAR	0x04
 
 #define SPD_tWRmin		17
@@ -232,6 +232,7 @@
 #define SPD_tRTPmin		27
 #define SPD_Upper_tFAW		28
 #define SPD_tFAWmin		29
+#define SPD_Thermal		31
 
 #define SPD_RefRawCard		62
 #define SPD_AddressMirror	63



More information about the coreboot-gerrit mailing list