[coreboot-gerrit] Patch merged into coreboot/master: memlayout: Fix unified CBFS_CACHE macro

gerrit at coreboot.org gerrit at coreboot.org
Thu Jan 21 09:05:42 CET 2016


the following patch was just integrated into master:
commit 757943c7d1ebdc109744aea37d3d999bf608a806
Author: Julius Werner <jwerner at chromium.org>
Date:   Wed Dec 16 16:07:39 2015 -0800

    memlayout: Fix unified CBFS_CACHE macro
    
    commit a8aef3ac (cbfs_spi: Initialize spi_flash when initializing
    cbfs_cache) introduced a bug that makes the rarely-used unified
    CBFS_CACHE() memlayout macro break when used in conjunction with
    cbfs_spi.c (since that macro does not define a separate
    postram_cbfs_cache region). This patch fixes the problem by making all
    three region names always available for both the unified and split
    macros in every stage (and adds code to ensure we don't reinitialize
    the same buffer again in romstage, which might be a bad idea if
    previous mappings are still in use).
    
    BRANCH=None
    BUG=None
    TEST=Compiled for both kinds of macros, manually checked symbols in
    disassembled stages.
    
    Change-Id: I114933e93080c8eceab04bfdba3aabf0f75f8ef9
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 0f270f88e54b42afb8b5057b0773644c4ef357ef
    Original-Change-Id: If172d9fa3d1fe587aa449bd4de7b5ca87d0f4915
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/318834
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://review.coreboot.org/12933
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See https://review.coreboot.org/12933 for details.

-gerrit



More information about the coreboot-gerrit mailing list