[coreboot-gerrit] New patch to review for coreboot: Makefile.inc: error if UPDATE_IMAGE is enabled with no coreboot.rom

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Wed Jan 20 22:59:45 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13065

-gerrit

commit 4f57cc09ce7eae7270a6673ebd1abd2c8fd568f9
Author: Martin Roth <martinroth at google.com>
Date:   Wed Jan 20 14:54:27 2016 -0700

    Makefile.inc: error if UPDATE_IMAGE is enabled with no coreboot.rom
    
    Instead of just failing with the statement:
    'mv: cannot stat ‘coreboot.rom’: No such file or directory',
    fail with an error that helps the user understand the issue.
    
    Change-Id: Ie693d45710f599991514e0803a7c444636e473c9
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.inc b/Makefile.inc
index c06ad45..0dd12a0 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -766,7 +766,7 @@ prebuild-files = \
 
 .PHONY: $(obj)/coreboot.pre
 $(obj)/coreboot.pre: $$(prebuilt-files) $(CBFSTOOL)
-	mv $(obj)/coreboot.rom $@.tmp
+	mv $(obj)/coreboot.rom $@.tmp | (echo "Error: You have UPDATE_IMAGE set in Kconfig, but have no existing image to update.  Exiting." && false)
 	$(prebuild-files) true
 	mv $@.tmp $@
 endif # ($(CONFIG_UPDATE_IMAGE),y)



More information about the coreboot-gerrit mailing list