[coreboot-gerrit] Patch set updated for coreboot: Makefile.inc: allow coreboot to be a git submodule

Ben Gardner (gardner.ben@gmail.com) gerrit at coreboot.org
Wed Jan 20 17:21:20 CET 2016


Ben Gardner (gardner.ben at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13061

-gerrit

commit c73d433e640005375c9618f9c22b239923d599a8
Author: Ben Gardner <gardner.ben at gmail.com>
Date:   Wed Jan 20 10:17:38 2016 -0600

    Makefile.inc: allow coreboot to be a git submodule
    
    When coreboot is pulled in as a submodule, the .git "folder" is a file,
    not a folder.  Use the '-e' test instead of '-d' to allow for that.
    
    Without this change, build.h will contain:
    #define COREBOOT_VERSION "coreboot-unknown"
    
    Change-Id: Ia141371cc892a0817d3566dc37ed0401675ad8d8
    Signed-off-by: Ben Gardner <gardner.ben at gmail.com>
---
 Makefile.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.inc b/Makefile.inc
index b1f5595..4d13719 100644
--- a/Makefile.inc
+++ b/Makefile.inc
@@ -13,7 +13,7 @@
 ## GNU General Public License for more details.
 ##
 
-GIT:=$(shell [ -d "$(top)/.git" ] && command -v git)
+GIT:=$(shell [ -e "$(top)/.git" ] && command -v git)
 
 #######################################################################
 # normalize Kconfig variables in a central place



More information about the coreboot-gerrit mailing list