[coreboot-gerrit] Patch set updated for coreboot: mediatek/mt8173: Add I2C driver

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Jan 19 18:13:50 CET 2016 

Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12615

-gerrit

commit b1fed0b708055fa0bff372d398ad6f16683bdaf5
Author: Liguo Zhang <liguo.zhang at mediatek.com>
Date:   Fri Jul 31 17:10:51 2015 +0800

    mediatek/mt8173: Add I2C driver
    
    BUG=none
    TEST=emerge-oak coreboot
    BRANCH=none
    
    Change-Id: If2cac5aecc5675048e0e2d28897b1a82e099de7d
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 2a3d867fd1e547cadc6c947f38082fddc2265d32
    Original-Change-Id: I4f3a9b403b949d8ae8e3c393cc9441fb66ea5f1d
    Original-Signed-off-by: liguo.zhang <liguo.zhang at mediatek.com>
    Original-Reviewed-on: https://chromium-review.googlesource.com/292667
    Original-Commit-Ready: Yidi Lin <yidi.lin at mediatek.com>
    Original-Tested-by: Yidi Lin <yidi.lin at mediatek.com>
    Original-Reviewed-by: Julius Werner <jwerner at chromium.org>
---
 src/mainboard/google/oak/Kconfig          |   1 -
 src/soc/mediatek/mt8173/Makefile.inc      |   1 +
 src/soc/mediatek/mt8173/i2c.c             | 333 ++++++++++++++++++++++++++++++
 src/soc/mediatek/mt8173/include/soc/i2c.h | 134 ++++++++++++
 4 files changed, 468 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/oak/Kconfig b/src/mainboard/google/oak/Kconfig
index 2e311a7..d63bdef 100644
--- a/src/mainboard/google/oak/Kconfig
+++ b/src/mainboard/google/oak/Kconfig
@@ -29,7 +29,6 @@ config BOARD_SPECIFIC_OPTIONS
 config CHROMEOS
 	select CHROMEOS_VBNV_EC
 	select EC_SOFTWARE_SYNC
-	select VBOOT2_MOCK_SECDATA
 	select VIRTUAL_DEV_SWITCH
 
 config MAINBOARD_DIR
diff --git a/src/soc/mediatek/mt8173/Makefile.inc b/src/soc/mediatek/mt8173/Makefile.inc
index 1b17d95..610d682 100644
--- a/src/soc/mediatek/mt8173/Makefile.inc
+++ b/src/soc/mediatek/mt8173/Makefile.inc
@@ -31,6 +31,7 @@ bootblock-y += mmu_operations.c
 
 ################################################################################
 
+verstage-y += i2c.c
 verstage-y += spi.c
 
 verstage-$(CONFIG_DRIVERS_UART) += uart.c
diff --git a/src/soc/mediatek/mt8173/i2c.c b/src/soc/mediatek/mt8173/i2c.c
new file mode 100644
index 0000000..6e383d4
--- /dev/null
+++ b/src/soc/mediatek/mt8173/i2c.c
@@ -0,0 +1,333 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2015 MediaTek Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#include <assert.h>
+#include <delay.h>
+#include <device/i2c.h>
+#include <string.h>
+#include <symbols.h>
+#include <timer.h>
+#include <arch/io.h>
+#include <soc/addressmap.h>
+#include <soc/i2c.h>
+#include <soc/pll.h>
+
+#define I2C_CLK_HZ (AXI_HZ / 16)
+
+static struct mtk_i2c i2c[7] = {
+	/* i2c0 setting */
+	{
+		.i2c_regs = (void *)I2C_BASE,
+		.i2c_dma_regs = (void *)(I2C_DMA_BASE + 0x80),
+	},
+
+	/* i2c1 setting */
+	{
+		.i2c_regs = (void *)(I2C_BASE + 0x1000),
+		.i2c_dma_regs = (void *)(I2C_DMA_BASE + 0x100),
+	},
+
+	/* i2c2 setting */
+	{
+		.i2c_regs = (void *)(I2C_BASE + 0x2000),
+		.i2c_dma_regs = (void *)(I2C_DMA_BASE + 0x180),
+	},
+
+	/* i2c3 setting */
+	{
+		.i2c_regs = (void *)(I2C_BASE + 0x9000),
+		.i2c_dma_regs = (void *)(I2C_DMA_BASE + 0x200),
+	},
+
+	/* i2c4 setting */
+	{
+		.i2c_regs = (void *)(I2C_BASE + 0xa000),
+		.i2c_dma_regs = (void *)(I2C_DMA_BASE + 0x280),
+	},
+
+	/* i2c5 is reserved for internal use. */
+	{
+	},
+
+	/* i2c6 setting */
+	{
+		.i2c_regs = (void *)(I2C_BASE + 0xc000),
+		.i2c_dma_regs = (void *)I2C_DMA_BASE,
+	}
+};
+
+#define I2CTAG                "[I2C][PL] "
+
+#if CONFIG_DEBUG_I2C
+#define I2CLOG(fmt, arg...)   printk(BIOS_INFO, I2CTAG fmt, ##arg)
+#else
+#define I2CLOG(fmt, arg...)
+#endif /* CONFIG_DEBUG_I2C */
+
+#define I2CERR(fmt, arg...)   printk(BIOS_ERR, I2CTAG fmt, ##arg)
+
+static inline void i2c_dma_reset(struct mt8173_i2c_dma_regs *dma_regs)
+{
+	write32(&dma_regs->dma_rst, 0x1);
+	udelay(50);
+	write32(&dma_regs->dma_rst, 0x2);
+	udelay(50);
+	write32(&dma_regs->dma_rst, 0x0);
+	udelay(50);
+}
+
+static inline void mtk_i2c_dump_info(uint8_t bus)
+{
+	struct mt8173_i2c_regs *regs;
+
+	regs = i2c[bus].i2c_regs;
+
+	I2CLOG("I2C register:\nSLAVE_ADDR %x\nINTR_MASK %x\nINTR_STAT %x\n"
+	       "CONTROL %x\nTRANSFER_LEN %x\nTRANSAC_LEN %x\nDELAY_LEN %x\n"
+	       "TIMING %x\nSTART %x\nFIFO_STAT %x\nIO_CONFIG %x\nHS %x\n"
+	       "DEBUGSTAT %x\nEXT_CONF %x\n",
+		(read32(&regs->salve_addr)),
+		(read32(&regs->intr_mask)),
+		(read32(&regs->intr_stat)),
+		(read32(&regs->control)),
+		(read32(&regs->transfer_len)),
+		(read32(&regs->transac_len)),
+		(read32(&regs->delay_len)),
+		(read32(&regs->timing)),
+		(read32(&regs->start)),
+		(read32(&regs->fifo_stat)),
+		(read32(&regs->io_config)),
+		(read32(&regs->hs)),
+		(read32(&regs->debug_stat)),
+		(read32(&regs->ext_conf)));
+
+	I2CLOG("addr address %x\n", (uint32_t)regs);
+}
+
+static uint32_t mtk_i2c_transfer(uint8_t bus, struct i2c_seg *seg,
+				 enum i2c_modes read)
+{
+	uint32_t ret_code = I2C_OK;
+	uint16_t status;
+	uint32_t time_out_val = 0;
+	uint8_t  addr;
+	uint32_t write_len = 0;
+	uint32_t read_len = 0;
+	uint8_t *write_buffer = NULL;
+	uint8_t *read_buffer = NULL;
+	uint8_t sample_div;
+	uint8_t step_div;
+	uint32_t i2c_freq;
+	struct mt8173_i2c_regs *regs;
+	struct mt8173_i2c_dma_regs *dma_regs;
+	struct stopwatch sw;
+
+	regs = i2c[bus].i2c_regs;
+	dma_regs = i2c[bus].i2c_dma_regs;
+
+	addr = seg[0].chip;
+
+	switch (read) {
+	case I2C_WRITE_MODE:
+		assert(seg[0].len > 0 && seg[0].len <= 255);
+		write_len = seg[0].len;
+		write_buffer = seg[0].buf;
+		break;
+
+	case I2C_READ_MODE:
+		assert(seg[0].len > 0 && seg[0].len <= 255);
+		read_len = seg[0].len;
+		read_buffer = seg[0].buf;
+		break;
+
+	/* Must use special write-then-read mode for repeated starts. */
+	case I2C_WRITE_READ_MODE:
+		assert(seg[0].len > 0 && seg[0].len <= 255);
+		assert(seg[1].len > 0 && seg[1].len <= 255);
+		write_len = seg[0].len;
+		read_len = seg[1].len;
+		write_buffer = seg[0].buf;
+		read_buffer = seg[1].buf;
+		break;
+	}
+
+	/* Calculate i2c frequency */
+	sample_div = 1;
+	step_div = div_round_up(I2C_CLK_HZ, (400 * KHz * sample_div * 2));
+	i2c_freq = I2C_CLK_HZ / (step_div * sample_div * 2);
+	assert(sample_div < 8 && i2c_freq < 400 * KHz && i2c_freq >= 380 * KHz);
+	write32(&regs->timing, (sample_div - 1) << 8 | (step_div - 1));
+
+	/* Clear interrupt status */
+	write32(&regs->intr_stat, I2C_TRANSAC_COMP | I2C_ACKERR |
+		I2C_HS_NACKERR);
+
+	write32(&regs->fifo_addr_clr, 0x1);
+
+	/* Enable interrupt */
+	write32(&regs->intr_mask, I2C_HS_NACKERR | I2C_ACKERR |
+		I2C_TRANSAC_COMP);
+
+	switch (read) {
+	case I2C_WRITE_MODE:
+		memcpy(_dma_coherent, write_buffer, write_len);
+
+		/* control registers */
+		write32(&regs->control, ACK_ERR_DET_EN | DMA_EN | CLK_EXT |
+			REPEATED_START_FLAG);
+
+		/* Set transfer and transaction len */
+		write32(&regs->transac_len, 1);
+		write32(&regs->transfer_len, write_len);
+
+		/* set i2c write slave address*/
+		write32(&regs->slave_addr, addr << 1);
+
+		/* Prepare buffer data to start transfer */
+		write32(&dma_regs->dma_con, I2C_DMA_CON_TX);
+		write32(&dma_regs->dma_tx_mem_addr, (uintptr_t)_dma_coherent);
+		write32(&dma_regs->dma_tx_len, write_len);
+		break;
+
+	case I2C_READ_MODE:
+		/* control registers */
+		write32(&regs->control, ACK_ERR_DET_EN | DMA_EN | CLK_EXT |
+			REPEATED_START_FLAG);
+
+		/* Set transfer and transaction len */
+		write32(&regs->transac_len, 1);
+		write32(&regs->transfer_len, read_len);
+
+		/* set i2c read slave address*/
+		write32(&regs->slave_addr, (addr << 1 | 0x1));
+
+		/* Prepare buffer data to start transfer */
+		write32(&dma_regs->dma_con, I2C_DMA_CON_RX);
+		write32(&dma_regs->dma_rx_mem_addr, (uintptr_t)_dma_coherent);
+		write32(&dma_regs->dma_rx_len, read_len);
+		break;
+
+	case I2C_WRITE_READ_MODE:
+		memcpy(_dma_coherent, write_buffer, write_len);
+
+		/* control registers */
+		write32(&regs->control, DIR_CHG | ACK_ERR_DET_EN | DMA_EN |
+			CLK_EXT | REPEATED_START_FLAG);
+
+		/* Set transfer and transaction len */
+		write32(&regs->transfer_len, write_len);
+		write32(&regs->transfer_aux_len, read_len);
+		write32(&regs->transac_len, 2);
+
+		/* set i2c write slave address*/
+		write32(&regs->slave_addr, addr << 1);
+
+		/* Prepare buffer data to start transfer */
+		write32(&dma_regs->dma_con, I2C_DMA_CLR_FLAG);
+		write32(&dma_regs->dma_tx_mem_addr, (uintptr_t)_dma_coherent);
+		write32(&dma_regs->dma_tx_len, write_len);
+		write32(&dma_regs->dma_rx_mem_addr, (uintptr_t)_dma_coherent);
+		write32(&dma_regs->dma_rx_len, read_len);
+		break;
+	}
+
+	write32(&dma_regs->dma_int_flag, I2C_DMA_CLR_FLAG);
+	write32(&dma_regs->dma_en, I2C_DMA_START_EN);
+
+	/* start transfer transaction */
+	write32(&regs->start, 0x1);
+
+	stopwatch_init_msecs_expire(&sw, 100);
+
+	/* polling mode : see if transaction complete */
+	while (1) {
+		status = read32(&regs->intr_stat);
+		if (status & I2C_HS_NACKERR) {
+			ret_code = I2C_TRANSFER_FAIL_HS_NACKERR;
+			I2CERR("[i2c%d transfer] transaction NACK error\n",
+			       bus);
+			mtk_i2c_dump_info(bus);
+			break;
+		} else if (status & I2C_ACKERR) {
+			ret_code = I2C_TRANSFER_FAIL_ACKERR;
+			I2CERR("[i2c%d transfer] transaction ACK error\n", bus);
+			mtk_i2c_dump_info(bus);
+			break;
+		} else if (status & I2C_TRANSAC_COMP) {
+			ret_code = I2C_OK;
+			memcpy(read_buffer, _dma_coherent, read_len);
+			break;
+		}
+
+		if (stopwatch_expired(&sw)) {
+			ret_code = I2C_TRANSFER_FAIL_TIMEOUT;
+			I2CERR("[i2c%d transfer] transaction timeout:%d\n", bus,
+			       time_out_val);
+			mtk_i2c_dump_info(bus);
+			break;
+		}
+	}
+
+	write32(&regs->intr_stat, I2C_TRANSAC_COMP | I2C_ACKERR |
+		I2C_HS_NACKERR);
+
+	/* clear bit mask */
+	write32(&regs->intr_mask, I2C_HS_NACKERR | I2C_ACKERR |
+		I2C_TRANSAC_COMP);
+
+	/* reset the i2c controller for next i2c transfer. */
+	write32(&regs->softreset, 0x1);
+
+	i2c_dma_reset(dma_regs);
+
+	return ret_code;
+}
+
+static uint8_t mtk_i2c_should_combine(struct i2c_seg *seg, int left_count)
+{
+	if (left_count >= 2 && seg[0].read == 0 && seg[1].read == 1 &&
+	    seg[0].chip == seg[1].chip)
+		return 1;
+	else
+		return 0;
+}
+
+int platform_i2c_transfer(unsigned bus, struct i2c_seg *segments, int seg_count)
+{
+	int ret = 0;
+	int i;
+	int read;
+
+	for (i = 0; i < seg_count; i++) {
+		if (mtk_i2c_should_combine(&segments[i], seg_count - i))
+			read = I2C_WRITE_READ_MODE;
+		else
+			read = segments[i].read;
+
+		ret = mtk_i2c_transfer(bus, &segments[i], read);
+
+		if (ret)
+			break;
+
+		if (read == I2C_WRITE_READ_MODE)
+			i++;
+	}
+
+	return ret;
+}
diff --git a/src/soc/mediatek/mt8173/include/soc/i2c.h b/src/soc/mediatek/mt8173/include/soc/i2c.h
new file mode 100644
index 0000000..295a9aa
--- /dev/null
+++ b/src/soc/mediatek/mt8173/include/soc/i2c.h
@@ -0,0 +1,134 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2015 MediaTek Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA
+ */
+
+#ifndef SOC_MEDIATEK_MT8173_I2C_H
+#define SOC_MEDIATEK_MT8173_I2C_H
+
+#include <stddef.h>
+
+/* I2C Configuration */
+enum {
+	I2C_HS_DEFAULT_VALUE	 = 0x0102,
+};
+
+enum i2c_modes {
+	I2C_WRITE_MODE		= 0,
+	I2C_READ_MODE		= 1,
+	I2C_WRITE_READ_MODE	= 2,
+};
+
+enum {
+	I2C_DMA_CON_TX          = 0x0,
+	I2C_DMA_CON_RX          = 0x1,
+	I2C_DMA_START_EN        = 0x1,
+	I2C_DMA_INT_FLAG_NONE   = 0x0,
+	I2C_DMA_CLR_FLAG        = 0x0,
+	I2C_DMA_FLUSH_FLAG      = 0x1,
+};
+
+/* I2C DMA Registers */
+struct mt8173_i2c_dma_regs {
+	uint32_t dma_int_flag;
+	uint32_t dma_int_en;
+	uint32_t dma_en;
+	uint32_t dma_rst;
+	uint32_t reserved1;
+	uint32_t dma_flush;
+	uint32_t dma_con;
+	uint32_t dma_tx_mem_addr;
+	uint32_t dma_rx_mem_addr;
+	uint32_t dma_tx_len;
+	uint32_t dma_rx_len;
+};
+
+check_member(mt8173_i2c_dma_regs, dma_tx_len, 0x24);
+
+/* I2C Register */
+struct mt8173_i2c_regs {
+	uint32_t data_port;
+	uint32_t slave_addr;
+	uint32_t intr_mask;
+	uint32_t intr_stat;
+	uint32_t control;
+	uint32_t transfer_len;
+	uint32_t transac_len;
+	uint32_t delay_len;
+	uint32_t timing;
+	uint32_t start;
+	uint32_t ext_conf;
+	uint32_t reserved1;
+	uint32_t fifo_stat;
+	uint32_t fifo_thresh;
+	uint32_t fifo_addr_clr;
+	uint32_t reserved2;
+	uint32_t io_config;
+	uint32_t debug;
+	uint32_t hs;
+	uint32_t reserved3;
+	uint32_t softreset;
+	uint32_t dcm;
+	uint32_t reserved4[3];
+	uint32_t debug_stat;
+	uint32_t debug_ctrl;
+	uint32_t transfer_aux_len;
+};
+
+check_member(mt8173_i2c_regs, debug_stat, 0x64);
+
+struct mtk_i2c {
+	struct mt8173_i2c_regs *i2c_regs;
+	struct mt8173_i2c_dma_regs *i2c_dma_regs;
+};
+
+enum {
+	I2C_TRANS_LEN_MASK = (0xff),
+	I2C_TRANS_AUX_LEN_MASK = (0x1f << 8),
+	I2C_CONTROL_MASK = (0x3f << 1)
+};
+
+/* Register mask */
+enum {
+	I2C_HS_NACKERR = (1 << 2),
+	I2C_ACKERR = (1 << 1),
+	I2C_TRANSAC_COMP = (1 << 0),
+};
+
+/* i2c control bits */
+enum {
+	ACK_ERR_DET_EN = (1 << 5),
+	DIR_CHG = (1 << 4),
+	CLK_EXT = (1 << 3),
+	DMA_EN = (1 << 2),
+	REPEATED_START_FLAG = (1 << 1),
+	STOP_FLAG = (0 << 1)
+};
+
+/* I2C Status Code */
+
+enum {
+	I2C_OK = 0x0000,
+	I2C_SET_SPEED_FAIL_OVER_SPEED = 0xA001,
+	I2C_TRANSFER_INVALID_LENGTH = 0xA002,
+	I2C_TRANSFER_FAIL_HS_NACKERR = 0xA003,
+	I2C_TRANSFER_FAIL_ACKERR = 0xA004,
+	I2C_TRANSFER_FAIL_TIMEOUT = 0xA005,
+	I2C_TRANSFER_INVALID_ARGUMENT = 0xA006
+};
+
+#endif /* SOC_MEDIATEK_MT8173_I2C_H */

More information about the coreboot-gerrit mailing list