[coreboot-gerrit] Patch merged into coreboot/master: google/chell: Adjust nuvoton 8825 button thresholds, add properties

gerrit at coreboot.org gerrit at coreboot.org
Tue Jan 19 16:40:00 CET 2016


the following patch was just integrated into master:
commit b7090ee1d0d35be6797234fe464b49f623bb7cc7
Author: Benson Leung <bleung at chromium.org>
Date:   Thu Jan 14 13:08:17 2016 -0800

    google/chell: Adjust nuvoton 8825 button thresholds, add properties
    
    Set "nuvoton,sar-threshold" property to thresholds
    based on tuning with the Android Wired Headphone
    Compatibility Kit and Chell EVT.
    
    Also set properties nuvoton,sar-compare-time and
    nuvoton,sar-sampling-time.
    
    The values of compare and sampling time align with
    the ones from this CL:
    https://chromium-review.googlesource.com/306372
    
    Signed-off-by: Benson Leung <bleung at chromium.org>
    
    BUG=chrome-os-partner:49333
    BRANCH=none
    TEST=Run evtest, selecting the input event for sklnau8825adi
    Using the Nominal headphones from the kit, check that the
    buttons for "KEY_VOLUMEDOWN", "KEY_VOLUMEUP", "KEY_MEDIA",
    and code 582 (?) (should be voice search, but evtest doesn't understand)
    All of these buttons should work properly.
    
    Change-Id: I43dc1957f7d95744f41039a306d323806e66c56a
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Original-Commit-Id: 2bb545500afeb5b4fa0d1cd02dbf6453f19901ab
    Original-Change-Id: I126aae1e5ed1b9e1a2429e8c94fe08b3ba3ca736
    Original-Reviewed-on: https://chromium-review.googlesource.com/322243
    Original-Commit-Ready: Benson Leung <bleung at chromium.org>
    Original-Tested-by: Benson Leung <bleung at chromium.org>
    Original-Reviewed-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://review.coreboot.org/13013
    Tested-by: build bot (Jenkins)
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Reviewed-by: Martin Roth <martinroth at google.com>


See https://review.coreboot.org/13013 for details.

-gerrit



More information about the coreboot-gerrit mailing list