[coreboot-gerrit] Patch set updated for coreboot: arch/x86/Makefile.inc: Add a comment to fix syntax highlighting

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Mon Jan 18 18:53:33 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13017

-gerrit

commit 62712cfb41dcc3f5588c43903a6eb721a8746664
Author: Martin Roth <martinroth at google.com>
Date:   Fri Jan 15 11:12:04 2016 -0700

    arch/x86/Makefile.inc: Add a comment to fix syntax highlighting
    
    Trivial fix for syntax highlighting in editors.  Some get confused by
    the double quote that doesn't have a close quote and stop highlighting
    at that point.  This comment closes the quote and the paren pair so
    that they can recover.
    
    Change-Id: I2bdb7c953a86905fc302d77eb9ad1200958800b7
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/arch/x86/Makefile.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index 9713d52..cb3d31f 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -96,6 +96,7 @@ $(objgenerated)/bootblock.ld: $$(filter-out $(obj)/arch/x86/bootblock.bootblock.
 	mv $@.tmp $@
 
 $(objgenerated)/bootblock.inc: $(src)/arch/x86/$(subst ",,$(CONFIG_BOOTBLOCK_SOURCE)) $(objutil)/romcc/romcc $(OPTION_TABLE_H) $(KCONFIG_AUTOHEADER)
+# The open quote in the subst messes with syntax highlighting. Fix it - ")
 	@printf "    ROMCC      $(subst $(obj)/,,$(@))\n"
 	$(CC_bootblock) $(CPPFLAGS_bootblock) -MM -MT$(objgenerated)/bootblock.inc \
 		$< > $(objgenerated)/bootblock.inc.d



More information about the coreboot-gerrit mailing list