[coreboot-gerrit] New patch to review for coreboot: nb/intel/pineview: Fix decode_pciebar()

Damien Zammit (damien@zamaudio.com) gerrit at coreboot.org
Mon Jan 18 07:14:24 CET 2016


Damien Zammit (damien at zamaudio.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/13031

-gerrit

commit 2bf73cec29f4fb68bee8f234470c0aac818b9a88
Author: Damien Zammit <damien at zamaudio.com>
Date:   Mon Jan 18 16:29:42 2016 +1100

    nb/intel/pineview: Fix decode_pciebar()
    
    Fixes bug that decode_pciebar() function was bypassed due
    to PCI_DEV(0,0,0) being detected as zero and function returning 0.
    
    Change-Id: Ia79bcebbe3ba36f479cbb24dbbb163a031d9c099
    Signed-off-by: Damien Zammit <damien at zamaudio.com>
---
 src/northbridge/intel/pineview/ram_calc.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/northbridge/intel/pineview/ram_calc.c b/src/northbridge/intel/pineview/ram_calc.c
index c273071..af1ca72 100644
--- a/src/northbridge/intel/pineview/ram_calc.c
+++ b/src/northbridge/intel/pineview/ram_calc.c
@@ -42,9 +42,6 @@ u8 decode_pciebar(u32 *const base, u32 *const len)
 		{0,   0},
 	};
 
-	if (!dev)
-		return 0;
-
 	pciexbar_reg = pci_read_config32(dev, PCIEXBAR);
 
 	// MMCFG not supported or not enabled.



More information about the coreboot-gerrit mailing list