[coreboot-gerrit] Patch merged into coreboot/master: intel/skylake: Fix uninitialized variable warning

gerrit at coreboot.org gerrit at coreboot.org
Sat Jan 16 21:03:37 CET 2016


the following patch was just integrated into master:
commit 5d6929b1d7066bc7f1963eb2a511cdf734f33f94
Author: Martin Roth <martinroth at google.com>
Date:   Sat Jan 16 09:22:22 2016 -0700

    intel/skylake: Fix uninitialized variable warning
    
    I don't think the warning is valid, because we already verify
    that num_channels is 2 or 4 as soon as we enter the function.
    Adding the default case makes the compiler happy.
    
    Fixes warning:
    src/soc/intel/skylake/nhlt/dmic.c: In function 'nhlt_soc_add_dmic_array':
    src/soc/intel/skylake/nhlt/dmic.c:100:2: error: 'formats' may be used
    uninitialized in this function [-Werror=maybe-uninitialized]
    return nhlt_endpoint_add_formats(endp, formats, num_formats);
    ^
    
    Change-Id: Idc22c8478ff666af8915d780d7553909c3163690
    Signed-off-by: Martin Roth <martinroth at google.com>
    Reviewed-on: https://review.coreboot.org/13021
    Tested-by: build bot (Jenkins)
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See https://review.coreboot.org/13021 for details.

-gerrit



More information about the coreboot-gerrit mailing list