[coreboot-gerrit] Patch merged into coreboot/master: nb/intel/sandybridge: Fix PEG disablement

gerrit at coreboot.org gerrit at coreboot.org
Thu Jan 14 21:20:30 CET 2016


the following patch was just integrated into master:
commit ad342a4589df6c51c96c1e9110979964b244fec3
Author: Patrick Rudolph <siro at das-labor.org>
Date:   Wed Oct 21 18:05:01 2015 +0200

    nb/intel/sandybridge: Fix PEG disablement
    
    Fix regression introduced by:
    3660c0fc658e4e20ef079f762dfc7ad05c83544c
    "northbridge/intel/sandybridge: Enable PEG clock-gating on demand"
    
    Issue observed:
    GNU/Linux kernel crashes in earlyinit on systems without PEG devices.
    The crash occurs on every boot in different functions.
    There's no problem on systems with PEG enabled.
    
    Test system:
     * Lenovo T530
     * Intel Core i5-3320M CPU
     * Fedora GNU/Linux 4.1
     * PEG disabled in devicetree
    
    Problem description:
    Tests shows that modifing PEG chicken bit or device enable bits
    after setting BIOS_RESET_CPL causes random crashes in GNU/Linux.
    
    Problem solution:
    Disable PEG devices before setting BIOS_RESET_CPL.
    
    Final testing results:
    No more random kernel crashes.
    
    Change-Id: I4a967c2d00d7d1e4426cf5abdd5f616c21557da7
    Signed-off-by: Patrick Rudolph <siro at das-labor.org>
    Reviewed-on: http://review.coreboot.org/12112
    Tested-by: build bot (Jenkins)
    Reviewed-by: Nico Huber <nico.h at gmx.de>
    (cherry picked from commit aad34cda4bc9c14ed10b00fe5da3f32233257913)
    Reviewed-on: https://review.coreboot.org/12456
    Reviewed-by: Stefan Reinauer <stefan.reinauer at coreboot.org>


See https://review.coreboot.org/12456 for details.

-gerrit



More information about the coreboot-gerrit mailing list