[coreboot-gerrit] Patch set updated for coreboot: vendorcode/chromeos: Make VBOOT NV backend a Kconfig "choice"

Alexandru Gagniuc (mr.nuke.me@gmail.com) gerrit at coreboot.org
Tue Jan 12 19:19:08 CET 2016


Alexandru Gagniuc (mr.nuke.me at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12908

-gerrit

commit 010a189930ac04c9cbb590cfdd8659a8c3c104e0
Author: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
Date:   Tue Jan 12 09:14:49 2016 -0800

    vendorcode/chromeos: Make VBOOT NV backend a Kconfig "choice"
    
    With VBOOT_VERIFY_FIRMWARE, the symbols "save_vbnv" and "read_vbnv"
    must be provided. This is done by selecting one of the CHROMEOS_VBNV_*
    options. Make that a "choice" menu so that one of the implementations
    is always pulled in, and the vbnv dependencies are satisfied.
    
    Change-Id: Id369af9882e3cae810787bf42a5423960c01f083
    Signed-off-by: Alexandru Gagniuc <alexandrux.gagniuc at intel.com>
---
 src/vendorcode/google/chromeos/Kconfig | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/src/vendorcode/google/chromeos/Kconfig b/src/vendorcode/google/chromeos/Kconfig
index 87fc024..1960268 100644
--- a/src/vendorcode/google/chromeos/Kconfig
+++ b/src/vendorcode/google/chromeos/Kconfig
@@ -1,6 +1,8 @@
 ## This file is part of the coreboot project.
 ##
 ## Copyright (C) 2011 The ChromiumOS Authors.  All rights reserved.
+## Copyright (C) 2015 Intel Corp.
+## (Written by Alexandru Gagniuc <alexandrux.gagniuc at intel.com> for Intel Corp.)
 ##
 ## This program is free software; you can redistribute it and/or modify
 ## it under the terms of the GNU General Public License as published by
@@ -52,23 +54,27 @@ config VBNV_SIZE
 	  CMOS storage size for VbNv data. This value must match cmos.layout
 	  in the mainboard directory.
 
+choice
+	prompt "Storage backend for Vboot non-volatile data"
+	depends on VBOOT_VERIFY_FIRMWARE
+
 config CHROMEOS_VBNV_CMOS
 	bool "Vboot non-volatile storage in CMOS."
-	default n
 	help
 	  VBNV is stored in CMOS
 
 config CHROMEOS_VBNV_EC
 	bool "Vboot non-volatile storage in EC."
-	default n
 	help
 	  VBNV is stored in EC
 
 config CHROMEOS_VBNV_FLASH
-	def_bool n
+	bool "Vboot non-volatile storage in FLASH."
 	help
 	  VBNV is stored in flash storage
 
+endchoice
+
 config CHROMEOS_RAMOOPS
 	bool "Reserve space for Chrome OS ramoops"
 	default y



More information about the coreboot-gerrit mailing list