[coreboot-gerrit] Patch set updated for coreboot: mainboard/lenovo: reserve century byte

Alexander Couzens (lynxis@fe80.eu) gerrit at coreboot.org
Sun Jan 10 04:34:24 CET 2016


Alexander Couzens (lynxis at fe80.eu) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/11853

-gerrit

commit 42c3afa49bb1ccbe9072243a058657e2b627ce1d
Author: Alexander Couzens <lynxis at fe80.eu>
Date:   Sat Oct 10 16:04:59 2015 +0200

    mainboard/lenovo: reserve century byte
    
    The century byte is used by most RTC (default 0x32 at nvram).
    Even the century byte can disabled via ACPI it's more safe to reserve
    it's space. Because some RTC will act with that byte anyhow.
    Some OS overwrite it when syncronize the RTC.
    
    Change-Id: I078c0c57215ccb925afa85b9d067f15268801ec9
    Signed-off-by: Alexander Couzens <lynxis at fe80.eu>
---
 src/mainboard/lenovo/g505s/cmos.layout |  3 ++-
 src/mainboard/lenovo/t400/cmos.layout  |  7 ++++---
 src/mainboard/lenovo/t420s/cmos.layout |  6 ++++--
 src/mainboard/lenovo/t430s/cmos.layout |  5 +++--
 src/mainboard/lenovo/t520/cmos.layout  |  5 +++--
 src/mainboard/lenovo/t530/cmos.layout  |  6 ++++--
 src/mainboard/lenovo/t60/cmos.layout   | 10 ++++++----
 src/mainboard/lenovo/x200/cmos.layout  |  5 ++---
 src/mainboard/lenovo/x201/cmos.layout  |  6 +++---
 src/mainboard/lenovo/x220/cmos.layout  |  3 ++-
 src/mainboard/lenovo/x230/cmos.layout  |  6 ++++--
 src/mainboard/lenovo/x60/cmos.layout   | 10 ++++++----
 12 files changed, 43 insertions(+), 29 deletions(-)

diff --git a/src/mainboard/lenovo/g505s/cmos.layout b/src/mainboard/lenovo/g505s/cmos.layout
index d83bb14..61c5690 100644
--- a/src/mainboard/lenovo/g505s/cmos.layout
+++ b/src/mainboard/lenovo/g505s/cmos.layout
@@ -24,7 +24,8 @@ entries
 396          1       e       1        interleave_chip_selects
 397          2       e       8        max_mem_clock
 399          1       e       2        multi_core
-400          1       e       1        power_on_after_fail
+#400         8       r       8        reserved for century byte
+408          1       e       1        power_on_after_fail
 412          4       e       6        debug_level
 440          4       e       9        slow_cpu
 444          1       e       1        nmi
diff --git a/src/mainboard/lenovo/t400/cmos.layout b/src/mainboard/lenovo/t400/cmos.layout
index e9764a5..8e642f8 100644
--- a/src/mainboard/lenovo/t400/cmos.layout
+++ b/src/mainboard/lenovo/t400/cmos.layout
@@ -53,8 +53,7 @@ entries
 395           4       e       6        debug_level
 #399          1       r       0        unused
 
-# coreboot config options: EC
-400         8       h       0        volume
+#400          8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408         1       e       10        sata_mode
@@ -82,8 +81,10 @@ entries
 
 # coreboot config options: graphics
 944         2       e       12       hybrid_graphics_mode
+#946        6       r       0        unused
 
-#946          2       r       0        unused
+# coreboot config options: EC
+952         8       h       0        volume
 
 # coreboot config options: check sums
 984          16       h       0        check_sum
diff --git a/src/mainboard/lenovo/t420s/cmos.layout b/src/mainboard/lenovo/t420s/cmos.layout
index cb76e70..4362840 100644
--- a/src/mainboard/lenovo/t420s/cmos.layout
+++ b/src/mainboard/lenovo/t420s/cmos.layout
@@ -52,7 +52,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -77,7 +77,9 @@ entries
 
 # coreboot config options: northbridge
 432          3       e       11       gfx_uma_size
-#435          549     r       0        unused
+#435         5       r       0        unused
+
+440          8       h       0        volume
 
 # SandyBridge MRC Scrambler Seed values
 896          32      r       0        mrc_scrambler_seed
diff --git a/src/mainboard/lenovo/t430s/cmos.layout b/src/mainboard/lenovo/t430s/cmos.layout
index 0d3d089..16b499a 100644
--- a/src/mainboard/lenovo/t430s/cmos.layout
+++ b/src/mainboard/lenovo/t430s/cmos.layout
@@ -52,7 +52,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -77,7 +77,8 @@ entries
 
 # coreboot config options: northbridge
 432          3       e       11       gfx_uma_size
-#435          549     r       0        unused
+#435         5       r       0        unused
+440          8       h       0        volume
 
 # SandyBridge MRC Scrambler Seed values
 896          32      r       0        mrc_scrambler_seed
diff --git a/src/mainboard/lenovo/t520/cmos.layout b/src/mainboard/lenovo/t520/cmos.layout
index bd9fd2a..2cf3629 100644
--- a/src/mainboard/lenovo/t520/cmos.layout
+++ b/src/mainboard/lenovo/t520/cmos.layout
@@ -52,7 +52,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -77,7 +77,8 @@ entries
 
 # coreboot config options: northbridge
 432         3        e      11        gfx_uma_size
-#435        549       r       0        unused
+#435        5        r       0        unused
+440         8        h       0        volume
 
 # SandyBridge MRC Scrambler Seed values
 896         32        r       0        mrc_scrambler_seed
diff --git a/src/mainboard/lenovo/t530/cmos.layout b/src/mainboard/lenovo/t530/cmos.layout
index bd9fd2a..e21c197 100644
--- a/src/mainboard/lenovo/t530/cmos.layout
+++ b/src/mainboard/lenovo/t530/cmos.layout
@@ -52,7 +52,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -77,7 +77,9 @@ entries
 
 # coreboot config options: northbridge
 432         3        e      11        gfx_uma_size
-#435        549       r       0        unused
+#435        5        r       0        unused
+
+440          8       h       0        volume
 
 # SandyBridge MRC Scrambler Seed values
 896         32        r       0        mrc_scrambler_seed
diff --git a/src/mainboard/lenovo/t60/cmos.layout b/src/mainboard/lenovo/t60/cmos.layout
index 29ea2ef..e5879d6 100644
--- a/src/mainboard/lenovo/t60/cmos.layout
+++ b/src/mainboard/lenovo/t60/cmos.layout
@@ -52,9 +52,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-# coreboot config options: cpu
-400          1       e       2        hyper_threading
-#401          7       r       0        unused
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -66,7 +64,11 @@ entries
 928          8       h       0        boot_default
 936          1       e       8        cmos_defaults_loaded
 937          1       e       1        lpt
-#938         46       r       0        unused
+#938         7       r       0        unused
+
+# coreboot config options: cpu
+944          1       e       2        hyper_threading
+#945         7       r       0        unused
 
 # coreboot config options: check sums
 984         16       h       0        check_sum
diff --git a/src/mainboard/lenovo/x200/cmos.layout b/src/mainboard/lenovo/x200/cmos.layout
index 5f50bd4..931cb4a 100644
--- a/src/mainboard/lenovo/x200/cmos.layout
+++ b/src/mainboard/lenovo/x200/cmos.layout
@@ -53,8 +53,7 @@ entries
 395           4       e       6        debug_level
 #399          1       r       0        unused
 
-# coreboot config options: EC
-400         8       h       0        volume
+#400          8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408         1       e       10        sata_mode
@@ -80,7 +79,7 @@ entries
 # coreboot config options: northbridge
 941         3       e       11       gfx_uma_size
 
-#944          2       r       0        unused
+944         8       h       0        volume
 
 # coreboot config options: check sums
 984          16       h       0        check_sum
diff --git a/src/mainboard/lenovo/x201/cmos.layout b/src/mainboard/lenovo/x201/cmos.layout
index d231a11..7d4aeae 100644
--- a/src/mainboard/lenovo/x201/cmos.layout
+++ b/src/mainboard/lenovo/x201/cmos.layout
@@ -52,7 +52,7 @@ entries
 395          4       e       6        debug_level
 #399         1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -75,8 +75,8 @@ entries
 
 # coreboot config options: northbridge
 424         3       e       10       gfx_uma_size
-
-#427        557     r       0        unused
+#427         5       r       0       unused
+432          8       h       0        volume
 
 # coreboot config options: check sums
 984         16       h       0        check_sum
diff --git a/src/mainboard/lenovo/x220/cmos.layout b/src/mainboard/lenovo/x220/cmos.layout
index 8f147cc..ca2c45c 100644
--- a/src/mainboard/lenovo/x220/cmos.layout
+++ b/src/mainboard/lenovo/x220/cmos.layout
@@ -52,7 +52,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -78,6 +78,7 @@ entries
 # coreboot config options: northbridge
 432         3        e      11        gfx_uma_size
 #435        549       r       0        unused
+440         8       h       0        volume
 
 # SandyBridge MRC Scrambler Seed values
 896         32        r       0        mrc_scrambler_seed
diff --git a/src/mainboard/lenovo/x230/cmos.layout b/src/mainboard/lenovo/x230/cmos.layout
index e8cd140..29c2066 100644
--- a/src/mainboard/lenovo/x230/cmos.layout
+++ b/src/mainboard/lenovo/x230/cmos.layout
@@ -52,7 +52,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-400          8       h       0        volume
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -77,7 +77,9 @@ entries
 
 # coreboot config options: northbridge
 432         3        e      11        gfx_uma_size
-#435        549       r       0        unused
+#435        5        r       0        unused
+
+440          8       h       0        volume
 
 # SandyBridge MRC Scrambler Seed values
 896         32        r       0        mrc_scrambler_seed
diff --git a/src/mainboard/lenovo/x60/cmos.layout b/src/mainboard/lenovo/x60/cmos.layout
index e267bb5..54a2799 100644
--- a/src/mainboard/lenovo/x60/cmos.layout
+++ b/src/mainboard/lenovo/x60/cmos.layout
@@ -52,9 +52,7 @@ entries
 395          4       e       6        debug_level
 #399          1       r       0        unused
 
-# coreboot config options: cpu
-400          1       e       2        hyper_threading
-#401          7       r       0        unused
+#400         8       r       0        reserved for century byte
 
 # coreboot config options: southbridge
 408          1       e       1        nmi
@@ -66,7 +64,11 @@ entries
 928          8       h       0        boot_default
 936          1       e       8        cmos_defaults_loaded
 937          1       e       1        lpt
-#938         46       r       0        unused
+#938         6       r       0        unused
+
+# coreboot config options: cpu
+944          1       e       2        hyper_threading
+#945         7       r       0        unused
 
 # coreboot config options: check sums
 984         16       h       0        check_sum



More information about the coreboot-gerrit mailing list