[coreboot-gerrit] New patch to review for coreboot: fsp1_1: Remove #if protection in header - It's not needed

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Thu Jan 7 23:36:05 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12859

-gerrit

commit b5a9376c447a500bd9f478a7dab59ab8f9ecd2b4
Author: Martin Roth <martinroth at google.com>
Date:   Thu Jan 7 15:33:38 2016 -0700

    fsp1_1: Remove #if protection in header - It's not needed
    
    There's nothing in these files that needs to be hidden if
    GOP support is disabled.  Removing this allows skylake to
    build when GOP support is turned off.
    
    Change-Id: I2a4f47cd435f48668311719f388b502ae77eca99
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 src/drivers/intel/fsp1_1/include/fsp/gop.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/src/drivers/intel/fsp1_1/include/fsp/gop.h b/src/drivers/intel/fsp1_1/include/fsp/gop.h
index 8277a23..29d6a6c 100644
--- a/src/drivers/intel/fsp1_1/include/fsp/gop.h
+++ b/src/drivers/intel/fsp1_1/include/fsp/gop.h
@@ -16,12 +16,8 @@
 #ifndef _FSP1_1_GOP_H_
 #define _FSP1_1_GOP_H_
 
-/* GOP support */
-#if IS_ENABLED(CONFIG_GOP_SUPPORT)
-
 #include <fsp/gma.h>
 
 const optionrom_vbt_t *fsp_get_vbt(uint32_t *vbt_len);
 
-#endif /* CONFIG_GOP_SUPPORT */
 #endif /* _FSP_GOP_H_ */



More information about the coreboot-gerrit mailing list