[coreboot-gerrit] New patch to review for coreboot: xcompile: Add separation for architectures to improve readability

Martin Roth (martinroth@google.com) gerrit at coreboot.org
Tue Jan 5 23:01:18 CET 2016


Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/12838

-gerrit

commit 83fa68341d03d0f7a60db0f7c161565bd517825e
Author: Martin Roth <martinroth at google.com>
Date:   Tue Jan 5 14:21:02 2016 -0700

    xcompile: Add separation for architectures to improve readability
    
    - Add bar at the top of each architecture
    - Make the architecture name and the TARCH_SEARCH to two lines
    - Add a second line at the bottom of each architecture
    - Add a comment about the two blank lines so they don't get
    accidentally removed.
    
    Change-Id: Ib4326bd94fe39b979244816ce54b752d083f6b16
    Signed-off-by: Martin Roth <martinroth at google.com>
---
 util/xcompile/xcompile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/util/xcompile/xcompile b/util/xcompile/xcompile
index 82a5885..3535793 100755
--- a/util/xcompile/xcompile
+++ b/util/xcompile/xcompile
@@ -225,7 +225,9 @@ STRIP_${TARCH}:=${GCCPREFIX}strip
 AR_${TARCH}:=${GCCPREFIX}ar
 CROSS_COMPILE_${TARCH}:=${GCCPREFIX}
 
+
 EOF
+#The two blank lines above are intentional separators
 }
 
 # Architecture definitions
@@ -320,7 +322,9 @@ test_architecture() {
 		search="$search $toolchain-linux-gnu-"
 		search="$search $toolchain-"
 	done
-	echo "# $architecture TARCH_SEARCH=$search"
+	echo "###########################################################################"
+	echo "# $architecture"
+	echo "# TARCH_SEARCH=$search"
 
 	# Search toolchain by checking assembler capability.
 	for TBFDARCH in $TBFDARCHS; do



More information about the coreboot-gerrit mailing list