[coreboot-gerrit] New patch to review for coreboot: google/eve: Enable internal pull-up on PWRBTN#

Duncan Laurie (dlaurie@chromium.org) gerrit at coreboot.org
Sun Dec 25 01:13:49 CET 2016


Duncan Laurie (dlaurie at chromium.org) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17962

-gerrit

commit 45fcd3b99eb1515671c17dc2869591fb702998ac
Author: Duncan Laurie <dlaurie at chromium.org>
Date:   Sat Dec 24 16:05:52 2016 -0800

    google/eve: Enable internal pull-up on PWRBTN#
    
    Enable an internal pull-up on the power button input as a quick
    press is resulting in power button override being asserted.
    
    BUG=chrome-os-partner:61312
    TEST=tested on eve P0b to ensure quick power button press does
    not result in a shutdown due to power button override.
    
    Change-Id: I3028cf7faef309cf4d60c3585b48adab6e1549d4
    Signed-off-by: Duncan Laurie <dlaurie at chromium.org>
---
 src/mainboard/google/eve/gpio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mainboard/google/eve/gpio.h b/src/mainboard/google/eve/gpio.h
index 10642e9..4505fb0 100644
--- a/src/mainboard/google/eve/gpio.h
+++ b/src/mainboard/google/eve/gpio.h
@@ -208,7 +208,7 @@ static const struct pad_config gpio_table[] = {
 /* BATLOW# */		PAD_CFG_NF(GPD0, NONE, DEEP, NF1),
 /* ACPRESENT */		PAD_CFG_NF(GPD1, NONE, DEEP, NF1),
 /* LAN_WAKE# */		PAD_CFG_NF(GPD2, NONE, DEEP, NF1), /* EC_PCH_WAKE_L */
-/* PWRBTN# */		PAD_CFG_NF(GPD3, NONE, DEEP, NF1),
+/* PWRBTN# */		PAD_CFG_NF(GPD3, 20K_PU, DEEP, NF1),
 /* SLP_S3# */		PAD_CFG_NF(GPD4, NONE, DEEP, NF1),
 /* SLP_S4# */		PAD_CFG_NF(GPD5, NONE, DEEP, NF1),
 /* SLP_A# */		PAD_CFG_NC(GPD6), /* TP26 */



More information about the coreboot-gerrit mailing list