[coreboot-gerrit] New patch to review for coreboot: mediatek/mt8173: Check the right set of bits in USB controller
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Thu Dec 15 14:48:46 CET 2016
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17875
-gerrit
commit 1b3b651de641df4bef8f2c0d2f9acd8660e34571
Author: Patrick Georgi <pgeorgi at chromium.org>
Date: Thu Dec 15 14:47:29 2016 +0100
mediatek/mt8173: Check the right set of bits in USB controller
Change-Id: Ic1d1b85a1d7e85b555a93b3a0b55fe310b26e34a
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Found-by: Coverity Scan #1353362
---
src/soc/mediatek/mt8173/usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/soc/mediatek/mt8173/usb.c b/src/soc/mediatek/mt8173/usb.c
index ac07646..1dccfc9 100644
--- a/src/soc/mediatek/mt8173/usb.c
+++ b/src/soc/mediatek/mt8173/usb.c
@@ -99,7 +99,7 @@ static int check_ip_clk_status(void)
u3_port_num = CAP_U3_PORT_NUM(read32(&ippc_regs->ip_xhci_cap));
check_bits = STS1_SYSPLL_STABLE | STS1_REF_RST | STS1_SYS125_RST;
- check_bits = (u3_port_num ? STS1_U3_MAC_RST : 0);
+ check_bits |= (u3_port_num ? STS1_U3_MAC_RST : 0);
stopwatch_init_usecs_expire(&sw, 50000);
More information about the coreboot-gerrit
mailing list