[coreboot-gerrit] New patch to review for coreboot: util/cbfstool: Fix memory leak

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Wed Dec 14 16:13:23 CET 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17859

-gerrit

commit b8c9eced24603f1994037e2d25ab62b2c59397a6
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Wed Dec 14 16:10:00 2016 +0100

    util/cbfstool: Fix memory leak
    
    Change-Id: I66cb1c88155ef58610bacfb899e0132e4143c7ac
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1325836
---
 util/cbfstool/cbfs_image.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/util/cbfstool/cbfs_image.c b/util/cbfstool/cbfs_image.c
index ee229b3..c34ca83 100644
--- a/util/cbfstool/cbfs_image.c
+++ b/util/cbfstool/cbfs_image.c
@@ -1411,6 +1411,7 @@ int cbfs_print_entry_info(struct cbfs_image *image, struct cbfs_file *entry,
 			ntohl(entry->len), hash_type, local_hash,
 			hash_len) != VB2_SUCCESS) {
 			fprintf(fp, "failed to hash '%s'\n", name);
+			free(hash_str);
 			break;
 		}
 		int valid = memcmp(local_hash, hash->hash_data, hash_len) == 0;



More information about the coreboot-gerrit mailing list