[coreboot-gerrit] Patch set updated for coreboot: vendorcode/amd: drop dead code
Patrick Georgi (pgeorgi@google.com)
gerrit at coreboot.org
Wed Dec 14 16:13:20 CET 2016
Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17833
-gerrit
commit b03bf0194dafacf90f0bb908c700c9f3e9bcbb2c
Author: Patrick Georgi <pgeorgi at chromium.org>
Date: Tue Dec 13 15:40:26 2016 +0100
vendorcode/amd: drop dead code
Change-Id: Ie67e1f7887e8df497d7dfd956badd9e06fd5d8a3
Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
Found-by: Coverity Scan #1254651
---
src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c | 5 -----
src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c | 5 -----
src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c | 5 -----
src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c | 5 -----
4 files changed, 20 deletions(-)
diff --git a/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c
index c207d67..ce1b5d9 100644
--- a/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00630F01/binaryPI/AGESA.c
@@ -368,13 +368,8 @@ AmdIdsRunApTaskLate (
IN AP_EXE_PARAMS *AmdApExeParams
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
AmdApExeParams->StdHeader.Func = -1;
return AGESA_UNSUPPORTED;
- if (!module) return AGESA_UNSUPPORTED;
- Dispatcher = module->ModuleDispatcher;
- return Dispatcher(AmdApExeParams);
}
/**********************************************************************
diff --git a/src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c
index 8d2c8e6..66a8393 100644
--- a/src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00660F01/binaryPI/AGESA.c
@@ -365,13 +365,8 @@ AmdIdsRunApTaskLate (
IN AP_EXE_PARAMS *AmdApExeParams
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
AmdApExeParams->StdHeader.Func = -1;
return AGESA_UNSUPPORTED;
- if (!module) return AGESA_UNSUPPORTED;
- Dispatcher = module->ModuleDispatcher;
- return Dispatcher(AmdApExeParams);
}
/**********************************************************************
diff --git a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
index 8d2c8e6..66a8393 100644
--- a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
@@ -365,13 +365,8 @@ AmdIdsRunApTaskLate (
IN AP_EXE_PARAMS *AmdApExeParams
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
AmdApExeParams->StdHeader.Func = -1;
return AGESA_UNSUPPORTED;
- if (!module) return AGESA_UNSUPPORTED;
- Dispatcher = module->ModuleDispatcher;
- return Dispatcher(AmdApExeParams);
}
/**********************************************************************
diff --git a/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c
index 82744dd..25364d8 100644
--- a/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00730F01/binaryPI/AGESA.c
@@ -366,13 +366,8 @@ AmdIdsRunApTaskLate (
IN AP_EXE_PARAMS *AmdApExeParams
)
{
- MODULE_ENTRY Dispatcher = NULL;
- const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
AmdApExeParams->StdHeader.Func = -1;
return AGESA_UNSUPPORTED;
- if (!module) return AGESA_UNSUPPORTED;
- Dispatcher = module->ModuleDispatcher;
- return Dispatcher(AmdApExeParams);
}
/**********************************************************************
More information about the coreboot-gerrit
mailing list