[coreboot-gerrit] New patch to review for coreboot: vendorcode/amd: drop dead code

Patrick Georgi (pgeorgi@google.com) gerrit at coreboot.org
Tue Dec 13 15:59:58 CET 2016


Patrick Georgi (pgeorgi at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17833

-gerrit

commit ea55dd5d0bf74e258e5618e7bccd7bcad5867b4f
Author: Patrick Georgi <pgeorgi at chromium.org>
Date:   Tue Dec 13 15:40:26 2016 +0100

    vendorcode/amd: drop dead code
    
    Change-Id: Ie67e1f7887e8df497d7dfd956badd9e06fd5d8a3
    Signed-off-by: Patrick Georgi <pgeorgi at chromium.org>
    Found-by: Coverity Scan #1254651
---
 src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
index 8d2c8e6..eb1db63 100644
--- a/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
+++ b/src/vendorcode/amd/pi/00670F00/binaryPI/AGESA.c
@@ -369,9 +369,6 @@ AmdIdsRunApTaskLate (
 	const AMD_MODULE_HEADER* module = agesawrapper_locate_module(ModuleIdentifier);
 	AmdApExeParams->StdHeader.Func = -1;
 	return AGESA_UNSUPPORTED;
-	if (!module) return AGESA_UNSUPPORTED;
-	Dispatcher = module->ModuleDispatcher;
-	return Dispatcher(AmdApExeParams);
 }
 
 /**********************************************************************



More information about the coreboot-gerrit mailing list