[coreboot-gerrit] New patch to review for coreboot: soc/intel/broadwell/lpc.c: don't zeroize existing gnvs table

Matt DeVillier (matt.devillier@gmail.com) gerrit at coreboot.org
Tue Dec 13 07:35:58 CET 2016


Matt DeVillier (matt.devillier at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17828

-gerrit

commit 51fb31f15bdd370ea8c0aadc58b2cf7140682541
Author: Matt DeVillier <matt.devillier at gmail.com>
Date:   Fri Jan 8 17:22:09 2016 -0800

    soc/intel/broadwell/lpc.c: don't zeroize existing gnvs table
    
    The gnvs table only needs to be zeroized after init;
    zeroizing an existing/populated table renders all I2C devices
    completely non-functional.
    
    TEST: boot Linux and observe all I2C devices functional
    
    Change-Id: Id149ad645dfe5ed999a65d10e786e17585abc477
    Signed-off-by: Matt DeVillier <matt.devillier at gmail.com>
---
 src/soc/intel/broadwell/lpc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/soc/intel/broadwell/lpc.c b/src/soc/intel/broadwell/lpc.c
index 850583b..e4db498 100644
--- a/src/soc/intel/broadwell/lpc.c
+++ b/src/soc/intel/broadwell/lpc.c
@@ -599,7 +599,6 @@ static void southcluster_inject_dsdt(device_t device)
 	}
 
 	if (gnvs) {
-		memset(gnvs, 0, sizeof(*gnvs));
 		acpi_create_gnvs(gnvs);
 		acpi_save_gnvs((unsigned long)gnvs);
 		/* And tell SMI about it */



More information about the coreboot-gerrit mailing list