[coreboot-gerrit] New patch to review for coreboot: lenovo: Don't use extern with functions

Kyösti Mälkki (kyosti.malkki@gmail.com) gerrit at coreboot.org
Mon Dec 12 21:49:10 CET 2016


Kyösti Mälkki (kyosti.malkki at gmail.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17804

-gerrit

commit 0bf9bcbd2b10065137b196b203b64be8269e1aa4
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Mon Dec 12 13:00:10 2016 +0200

    lenovo: Don't use extern with functions
    
    Change-Id: I8313ba1d93922297e5061701dad47d07617d1dcd
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
---
 src/mainboard/lenovo/t400/dock.h |  6 +++---
 src/mainboard/lenovo/t60/dock.h  | 12 ++++++------
 src/mainboard/lenovo/x200/dock.h |  6 +++---
 src/mainboard/lenovo/x201/dock.h |  6 +++---
 src/mainboard/lenovo/x60/dock.h  | 10 +++++-----
 5 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/src/mainboard/lenovo/t400/dock.h b/src/mainboard/lenovo/t400/dock.h
index ac6d81a..74b730c 100644
--- a/src/mainboard/lenovo/t400/dock.h
+++ b/src/mainboard/lenovo/t400/dock.h
@@ -16,7 +16,7 @@
 #ifndef THINKPAD_T400_DOCK_H
 #define THINKPAD_T400_DOCK_H
 
-extern void dock_connect(void);
-extern void dock_disconnect(void);
-extern int dock_present(void);
+void dock_connect(void);
+void dock_disconnect(void);
+int dock_present(void);
 #endif
diff --git a/src/mainboard/lenovo/t60/dock.h b/src/mainboard/lenovo/t60/dock.h
index ce8c98e..6a9efc2 100644
--- a/src/mainboard/lenovo/t60/dock.h
+++ b/src/mainboard/lenovo/t60/dock.h
@@ -16,11 +16,11 @@
 #ifndef THINKPAD_X60_DOCK_H
 #define THINKPAD_X60_DOCK_H
 
-extern int dock_connect(void);
-extern void dock_disconnect(void);
-extern int dock_present(void);
-extern int dlpc_init(void);
+int dock_connect(void);
+void dock_disconnect(void);
+int dock_present(void);
+int dlpc_init(void);
 
-extern int legacy_io_present(void);
-extern void legacy_io_init(void);
+int legacy_io_present(void);
+void legacy_io_init(void);
 #endif
diff --git a/src/mainboard/lenovo/x200/dock.h b/src/mainboard/lenovo/x200/dock.h
index fef0bf3..56f3fe0 100644
--- a/src/mainboard/lenovo/x200/dock.h
+++ b/src/mainboard/lenovo/x200/dock.h
@@ -16,7 +16,7 @@
 #ifndef THINKPAD_X200_DOCK_H
 #define THINKPAD_X200_DOCK_H
 
-extern void dock_connect(void);
-extern void dock_disconnect(void);
-extern int dock_present(void);
+void dock_connect(void);
+void dock_disconnect(void);
+int dock_present(void);
 #endif
diff --git a/src/mainboard/lenovo/x201/dock.h b/src/mainboard/lenovo/x201/dock.h
index 1af1b3d..4cd8c85 100644
--- a/src/mainboard/lenovo/x201/dock.h
+++ b/src/mainboard/lenovo/x201/dock.h
@@ -16,7 +16,7 @@
 #ifndef THINKPAD_X201_DOCK_H
 #define THINKPAD_X201_DOCK_H
 
-extern void dock_connect(void);
-extern void dock_disconnect(void);
-extern int dock_present(void);
+void dock_connect(void);
+void dock_disconnect(void);
+int dock_present(void);
 #endif
diff --git a/src/mainboard/lenovo/x60/dock.h b/src/mainboard/lenovo/x60/dock.h
index ef8a977..a8911dd 100644
--- a/src/mainboard/lenovo/x60/dock.h
+++ b/src/mainboard/lenovo/x60/dock.h
@@ -16,9 +16,9 @@
 #ifndef THINKPAD_X60_DOCK_H
 #define THINKPAD_X60_DOCK_H
 
-extern int dock_connect(void);
-extern void dock_disconnect(void);
-extern int dock_present(void);
-extern int dlpc_init(void);
-extern int dock_ultrabay_device_present(void);
+int dock_connect(void);
+void dock_disconnect(void);
+int dock_present(void);
+int dlpc_init(void);
+int dock_ultrabay_device_present(void);
 #endif



More information about the coreboot-gerrit mailing list