[coreboot-gerrit] New patch to review for coreboot: nb/intel/i945/udelay.c: Add comment for Pentium 4 frequency

HAOUAS Elyes (ehaouas@noos.fr) gerrit at coreboot.org
Mon Dec 12 21:05:22 CET 2016


HAOUAS Elyes (ehaouas at noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17801

-gerrit

commit fe480df902f5f1638133d909e4ffd4567d30ca86
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date:   Mon Dec 12 20:55:32 2016 +0100

    nb/intel/i945/udelay.c: Add comment for Pentium 4 frequency
    
    Change-Id: I2c8616c62ba65847dc59df7a07c547d63e297163
    Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
 src/northbridge/intel/i945/udelay.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/northbridge/intel/i945/udelay.c b/src/northbridge/intel/i945/udelay.c
index 27e616b..e15416f 100644
--- a/src/northbridge/intel/i945/udelay.c
+++ b/src/northbridge/intel/i945/udelay.c
@@ -31,6 +31,7 @@ void udelay(u32 us)
 	u32 fsb = 0, divisor;
 	u32 d;			/* ticks per us */
 
+	/* FIXME: for Pentium 4, we should read MSR_EBC_FREQUENCY_ID at 0x2c */
 	msr = rdmsr(MSR_FSB_FREQ);
 	switch (msr.lo & 0x07) {
 	case 5:



More information about the coreboot-gerrit mailing list