[coreboot-gerrit] Patch merged into coreboot/master: intel/i945: Use romstage_handoff for S3

gerrit at coreboot.org gerrit at coreboot.org
Sun Dec 11 08:58:13 CET 2016


the following patch was just integrated into master:
commit 8183025be9febdc8169db376d200537806772208
Author: Kyösti Mälkki <kyosti.malkki at gmail.com>
Date:   Sat Jun 25 11:40:00 2016 +0300

    intel/i945: Use romstage_handoff for S3
    
    Don't use scratchpad registers when we have romstage_handoff
    to pass S3 resume flag. Scratchpad register was read too
    late in ramstage so acpi_is_wakeup_s3() did not evaluate
    correctly.
    
    This fixes low memory corruption at 0x1000-0x102c and the lack
    of coreboot tables (util/cbmem not working) after S3 resume.
    
    This also fixes console log from reporting early in ramstage
    "Normal boot" while on "S3 resume" path.
    
    Change-Id: I2922a15a90d2f8272c3482579bdd96f8f33e9705
    Signed-off-by: Kyösti Mälkki <kyosti.malkki at gmail.com>
    Reviewed-on: https://review.coreboot.org/17675
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See https://review.coreboot.org/17675 for details.

-gerrit



More information about the coreboot-gerrit mailing list