[coreboot-gerrit] New patch to review for coreboot: soc/lowrisc: Place CBMEM at top of autodetected RAM

Jonathan Neuschäfer (j.neuschaefer@gmx.net) gerrit at coreboot.org
Sun Dec 4 09:27:58 CET 2016


Jonathan Neuschäfer (j.neuschaefer at gmx.net) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/17708

-gerrit

commit 8ad15834db54b90bd140035870435531e56f3a4d
Author: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
Date:   Thu Nov 24 08:26:03 2016 +0100

    soc/lowrisc: Place CBMEM at top of autodetected RAM
    
    Change-Id: I9f169db330d1792128db7a6308ed3afbe5803c03
    Signed-off-by: Jonathan Neuschäfer <j.neuschaefer at gmx.net>
---
 src/soc/lowrisc/lowrisc/cbmem.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/soc/lowrisc/lowrisc/cbmem.c b/src/soc/lowrisc/lowrisc/cbmem.c
index ea7ad70..44ffa26 100644
--- a/src/soc/lowrisc/lowrisc/cbmem.c
+++ b/src/soc/lowrisc/lowrisc/cbmem.c
@@ -11,13 +11,15 @@
  * GNU General Public License for more details.
  */
 
-#include <console/console.h>
 #include <cbmem.h>
+#include <commonlib/configstring.h>
 
 void *cbmem_top(void)
 {
-	// TODO: find out how the lowrisc SOC decides to provide
-	// this information, when they know.
-	printk(BIOS_SPEW, "Returning hard-coded 128M; fix me\n");
-	return (void *)((uintptr_t)(2ULL*GiB+128*MiB));
+	uintptr_t base;
+	size_t size;
+
+	query_mem(configstring(), &base, &size);
+
+	return (void *)(base + size);
 }



More information about the coreboot-gerrit mailing list