[coreboot-gerrit] Patch merged into coreboot/master: drivers/spi: remove unconditional RW boot device initialization
gerrit at coreboot.org
gerrit at coreboot.org
Wed Aug 24 15:46:40 CEST 2016
the following patch was just integrated into master:
commit 67e4df8b65c0b48717e3550089e7d230aeb6fe52
Author: Aaron Durbin <adurbin at chromium.org>
Date: Tue Aug 23 08:45:55 2016 -0500
drivers/spi: remove unconditional RW boot device initialization
The SPI drivers for the various chipsets are not consistent in
their handling of when they are accessible. Coupled with the
unknown ordering of boot_device_init() being called this can
lead to unexpected behavior (probing failures or hangs). Instead
move the act of initializing the SPI flash boot device to when
the various infrastructure requires its usage when it calls
boot_device_rw(). Those platforms utilizing the RW boot device
would need to ensure their SPI drivers are functional and
ready when the call happens.
This further removes any other systems failing to boot as
reported in https://ticket.coreboot.org/issues/67.
BUG=chrome-os-partner:56151
Change-Id: Ib3bddf5e26bf5322f3dd20345eeef6bee40f0f66
Signed-off-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-on: https://review.coreboot.org/16300
Tested-by: build bot (Jenkins)
Tested-by: Raptor Engineering Automated Test Stand <noreply at raptorengineeringinc.com>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Reviewed-by: Martin Roth <martinroth at google.com>
Reviewed-by: Werner Zeh <werner.zeh at siemens.com>
See https://review.coreboot.org/16300 for details.
-gerrit
More information about the coreboot-gerrit
mailing list