[coreboot-gerrit] Patch merged into coreboot/master: memlayout: Ensure TIMESTAMP() region is big enough to avoid BUG()
gerrit at coreboot.org
gerrit at coreboot.org
Tue Aug 23 21:33:33 CEST 2016
the following patch was just integrated into master:
commit 85b1aadcc1f0cec7eef73a527c5131fb3b1c2f95
Author: Julius Werner <jwerner at chromium.org>
Date: Fri Aug 19 15:17:42 2016 -0700
memlayout: Ensure TIMESTAMP() region is big enough to avoid BUG()
The timestamp code asserts that the _timestamp region (allocated in
memlayout for pre-RAM stages) is large enough for the assumptions it
makes. This is good, except that we often initialize timestamps
extremely early in the bootblock, even before console output. Debugging
a BUG() that hits before console_init() is no fun.
This patch adds a link-time assertion for the size of the _timestamp
region in memlayout to prevent people from accidentally running into
this issue.
Change-Id: Ibe4301fb89c47fde28e883fd11647d6b62a66fb0
Signed-off-by: Julius Werner <jwerner at chromium.org>
Reviewed-on: https://review.coreboot.org/16270
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin at chromium.org>
Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
Tested-by: Raptor Engineering Automated Test Stand <noreply at raptorengineeringinc.com>
See https://review.coreboot.org/16270 for details.
-gerrit
More information about the coreboot-gerrit
mailing list