[coreboot-gerrit] Patch merged into coreboot/master: drivers/spi: be sure to call spi_init() before spi_flash_probe()

gerrit at coreboot.org gerrit at coreboot.org
Tue Aug 23 15:17:03 CEST 2016


the following patch was just integrated into master:
commit df76f8983f001a83f00ad962e047dcb331a6d69f
Author: Aaron Durbin <adurbin at chromium.org>
Date:   Mon Aug 22 17:41:13 2016 -0500

    drivers/spi: be sure to call spi_init() before spi_flash_probe()
    
    It's necessary to call spi_init() prior to calling spi_flash_probe()
    such that the SPI drivers can do any work required prior to performing
    SPI transactions.  It could be argued that the drivers should handle
    such situations, however the SPI API implementations seem to assume the
    callers ensured spi_init() was called before any SPI transactions.
    
    This fixes systems that failed to boot introduced by [1]. Issue tracked
    in https://ticket.coreboot.org/issues/67.
    
    [1] I2aa75f88409309e3f9b9bd79b52d27c0061139c8
        https://review.coreboot.org/16200
    
    BUG=chrome-os-partner:56151
    
    Change-Id: I2d8d5ac685833521f1efe212b07a4b61ba0d9bc3
    Signed-off-by: Aaron Durbin <adurbin at chromium.org>
    Reviewed-on: https://review.coreboot.org/16297
    Tested-by: build bot (Jenkins)
    Reviewed-by: Philipp Deppenwiese <zaolin.daisuki at googlemail.com>
    Reviewed-by: Furquan Shaikh <furquan at google.com>
    Reviewed-by: Paul Menzel <paulepanter at users.sourceforge.net>
    Tested-by: Raptor Engineering Automated Test Stand <noreply at raptorengineeringinc.com>


See https://review.coreboot.org/16297 for details.

-gerrit



More information about the coreboot-gerrit mailing list