[coreboot-gerrit] Patch set updated for coreboot: src/device: Add required space before opening parenthesis '('

HAOUAS Elyes (ehaouas@noos.fr) gerrit at coreboot.org
Mon Aug 22 17:03:51 CEST 2016


HAOUAS Elyes (ehaouas at noos.fr) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16289

-gerrit

commit 72754bbd12c3d4cd589172ff91509ad701c7bc11
Author: Elyes HAOUAS <ehaouas at noos.fr>
Date:   Sun Aug 21 18:28:17 2016 +0200

    src/device: Add required space before opening parenthesis '('
    
    Change-Id: I48477c2917ab1be14d3cedf25e8b97dae1c1d309
    Signed-off-by: Elyes HAOUAS <ehaouas at noos.fr>
---
 src/device/oprom/x86emu/decode.c   |  4 ++--
 src/device/oprom/x86emu/ops.c      |  4 ++--
 src/device/oprom/x86emu/ops2.c     | 16 ++++++++--------
 src/device/oprom/x86emu/prim_ops.c |  4 ++--
 4 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/src/device/oprom/x86emu/decode.c b/src/device/oprom/x86emu/decode.c
index d59583c..b7a6f35 100644
--- a/src/device/oprom/x86emu/decode.c
+++ b/src/device/oprom/x86emu/decode.c
@@ -1138,9 +1138,9 @@ Return the offset given by "mod" addressing.
 
 unsigned decode_rmXX_address(int mod, int rm)
 {
-  if(mod == 0)
+  if (mod == 0)
     return decode_rm00_address(rm);
-  if(mod == 1)
+  if (mod == 1)
     return decode_rm01_address(rm);
   return decode_rm10_address(rm);
 }
diff --git a/src/device/oprom/x86emu/ops.c b/src/device/oprom/x86emu/ops.c
index c805b58..68658b1 100644
--- a/src/device/oprom/x86emu/ops.c
+++ b/src/device/oprom/x86emu/ops.c
@@ -211,7 +211,7 @@ static void x86emuOp_genop_byte_RM_R(u8 op1)
     DECODE_PRINTF(x86emu_GenOpName[op1]);
     DECODE_PRINTF("\t");
     FETCH_DECODE_MODRM(mod, rh, rl);
-    if(mod<3)
+    if (mod<3)
         { destoffset = decode_rmXX_address(mod,rl);
         DECODE_PRINTF(",");
         destval = fetch_data_byte(destoffset);
@@ -251,7 +251,7 @@ static void x86emuOp_genop_word_RM_R(u8 op1)
     DECODE_PRINTF("\t");
     FETCH_DECODE_MODRM(mod, rh, rl);
 
-    if(mod<3) {
+    if (mod<3) {
         destoffset = decode_rmXX_address(mod,rl);
         if (M.x86.mode & SYSMODE_PREFIX_DATA) {
             u32 destval;
diff --git a/src/device/oprom/x86emu/ops2.c b/src/device/oprom/x86emu/ops2.c
index 95ec09a..6089b1f 100644
--- a/src/device/oprom/x86emu/ops2.c
+++ b/src/device/oprom/x86emu/ops2.c
@@ -1507,7 +1507,7 @@ static void x86emuOp2_bsf(u8 X86EMU_UNUSED(op2))
             TRACE_AND_STEP();
             srcval = fetch_data_long(srcoffset);
             CONDITIONAL_SET_FLAG(srcval == 0, F_ZF);
-            for(*dstreg = 0; *dstreg < 32; (*dstreg)++)
+            for (*dstreg = 0; *dstreg < 32; (*dstreg)++)
                 if ((srcval >> *dstreg) & 1) break;
         } else {
             u16 srcval, *dstreg;
@@ -1516,7 +1516,7 @@ static void x86emuOp2_bsf(u8 X86EMU_UNUSED(op2))
             TRACE_AND_STEP();
             srcval = fetch_data_word(srcoffset);
             CONDITIONAL_SET_FLAG(srcval == 0, F_ZF);
-            for(*dstreg = 0; *dstreg < 16; (*dstreg)++)
+            for (*dstreg = 0; *dstreg < 16; (*dstreg)++)
                 if ((srcval >> *dstreg) & 1) break;
         }
     } else {             /* register to register */
@@ -1528,7 +1528,7 @@ static void x86emuOp2_bsf(u8 X86EMU_UNUSED(op2))
             dstreg = DECODE_RM_LONG_REGISTER(rh);
             TRACE_AND_STEP();
             CONDITIONAL_SET_FLAG(srcval == 0, F_ZF);
-            for(*dstreg = 0; *dstreg < 32; (*dstreg)++)
+            for (*dstreg = 0; *dstreg < 32; (*dstreg)++)
                 if ((srcval >> *dstreg) & 1) break;
         } else {
             u16 srcval, *dstreg;
@@ -1538,7 +1538,7 @@ static void x86emuOp2_bsf(u8 X86EMU_UNUSED(op2))
             dstreg = DECODE_RM_WORD_REGISTER(rh);
             TRACE_AND_STEP();
             CONDITIONAL_SET_FLAG(srcval == 0, F_ZF);
-            for(*dstreg = 0; *dstreg < 16; (*dstreg)++)
+            for (*dstreg = 0; *dstreg < 16; (*dstreg)++)
                 if ((srcval >> *dstreg) & 1) break;
         }
     }
@@ -1568,7 +1568,7 @@ static void x86emuOp2_bsr(u8 X86EMU_UNUSED(op2))
             TRACE_AND_STEP();
             srcval = fetch_data_long(srcoffset);
             CONDITIONAL_SET_FLAG(srcval == 0, F_ZF);
-            for(*dstreg = 31; *dstreg > 0; (*dstreg)--)
+            for (*dstreg = 31; *dstreg > 0; (*dstreg)--)
                 if ((srcval >> *dstreg) & 1) break;
         } else {
             u16 srcval, *dstreg;
@@ -1577,7 +1577,7 @@ static void x86emuOp2_bsr(u8 X86EMU_UNUSED(op2))
             TRACE_AND_STEP();
             srcval = fetch_data_word(srcoffset);
             CONDITIONAL_SET_FLAG(srcval == 0, F_ZF);
-            for(*dstreg = 15; *dstreg > 0; (*dstreg)--)
+            for (*dstreg = 15; *dstreg > 0; (*dstreg)--)
                 if ((srcval >> *dstreg) & 1) break;
         }
     } else {             /* register to register */
@@ -1589,7 +1589,7 @@ static void x86emuOp2_bsr(u8 X86EMU_UNUSED(op2))
             dstreg = DECODE_RM_LONG_REGISTER(rh);
             TRACE_AND_STEP();
             CONDITIONAL_SET_FLAG(srcval == 0, F_ZF);
-            for(*dstreg = 31; *dstreg > 0; (*dstreg)--)
+            for (*dstreg = 31; *dstreg > 0; (*dstreg)--)
                 if ((srcval >> *dstreg) & 1) break;
         } else {
             u16 srcval, *dstreg;
@@ -1599,7 +1599,7 @@ static void x86emuOp2_bsr(u8 X86EMU_UNUSED(op2))
             dstreg = DECODE_RM_WORD_REGISTER(rh);
             TRACE_AND_STEP();
             CONDITIONAL_SET_FLAG(srcval == 0, F_ZF);
-            for(*dstreg = 15; *dstreg > 0; (*dstreg)--)
+            for (*dstreg = 15; *dstreg > 0; (*dstreg)--)
                 if ((srcval >> *dstreg) & 1) break;
         }
     }
diff --git a/src/device/oprom/x86emu/prim_ops.c b/src/device/oprom/x86emu/prim_ops.c
index 08a22bd..8b2c38a 100644
--- a/src/device/oprom/x86emu/prim_ops.c
+++ b/src/device/oprom/x86emu/prim_ops.c
@@ -2295,7 +2295,7 @@ Implements the IN string instruction and side effects.
 
 static void single_in(int size)
 {
-    if(size == 1)
+    if (size == 1)
         store_data_byte_abs(M.x86.R_ES, M.x86.R_DI,(*sys_inb)(M.x86.R_DX));
     else if (size == 2)
         store_data_word_abs(M.x86.R_ES, M.x86.R_DI,(*sys_inw)(M.x86.R_DX));
@@ -2337,7 +2337,7 @@ Implements the OUT string instruction and side effects.
 
 static void single_out(int size)
 {
-     if(size == 1)
+     if (size == 1)
        (*sys_outb)(M.x86.R_DX,fetch_data_byte_abs(M.x86.R_ES, M.x86.R_SI));
      else if (size == 2)
        (*sys_outw)(M.x86.R_DX,fetch_data_word_abs(M.x86.R_ES, M.x86.R_SI));



More information about the coreboot-gerrit mailing list