[coreboot-gerrit] New patch to review for coreboot: qemu-riscv: Remove obsolete CSR - send_ipi
Martin Roth (martinroth@google.com)
gerrit at coreboot.org
Thu Aug 18 05:52:29 CEST 2016
Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16244
-gerrit
commit bc12d4123f202431ea2579e4dc708ded17983dc2
Author: Martin Roth <martinroth at google.com>
Date: Wed Aug 17 21:51:28 2016 -0600
qemu-riscv: Remove obsolete CSR - send_ipi
This aligns the code in qemu-riscv with the code in spike-riscv.
The previous code gives an error in the updated toolchain as the
send_ipi CSR is no longer valid.
This gave the build error:
src/mainboard/emulation/qemu-riscv/qemu_util.c:64:
Error: Instruction csrw requires absolute expression
Change-Id: Iac0f66e8e9935f45c8094d5e16bedb7ac5225424
Signed-off-by: Martin Roth <martinroth at google.com>
---
src/mainboard/emulation/qemu-riscv/qemu_util.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/src/mainboard/emulation/qemu-riscv/qemu_util.c b/src/mainboard/emulation/qemu-riscv/qemu_util.c
index 3c2941c..216eea9 100644
--- a/src/mainboard/emulation/qemu-riscv/qemu_util.c
+++ b/src/mainboard/emulation/qemu-riscv/qemu_util.c
@@ -56,14 +56,7 @@ uintptr_t mcall_query_memory(uintptr_t id, memory_block_info *p)
uintptr_t mcall_send_ipi(uintptr_t recipient)
{
- //if (recipient >= num_harts)
- //return -1;
-
- if (atomic_swap(&OTHER_HLS(recipient)->ipi_pending, 1) == 0) {
- mb();
- write_csr(send_ipi, recipient);
- }
-
+ die("mcall_send_ipi is currently not implemented");
return 0;
}
More information about the coreboot-gerrit
mailing list