[coreboot-gerrit] Patch merged into coreboot/master: intel/apollolake: Fix check for return value of pmc_gpe_route_to_gpio

gerrit at coreboot.org gerrit at coreboot.org
Thu Aug 18 01:07:39 CEST 2016


the following patch was just integrated into master:
commit e7de6fb162bb9a7c0551027514596d6d7f45421b
Author: Furquan Shaikh <furquan at google.com>
Date:   Sun Aug 14 21:50:50 2016 -0700

    intel/apollolake: Fix check for return value of pmc_gpe_route_to_gpio
    
    pmc_gpe_route_to_gpio returns -1 on error. However, the value was being
    stored in unsigned int and compared against -1. Fix this by using local
    variable ret.
    
    Change-Id: I5ec824949d4ee0fbdbb2ffdc9fc9d4762455b27b
    Reported-by: Coverity ID 1357443, 1357442, 1357441
    Signed-off-by: Furquan Shaikh <furquan at google.com>
    Reviewed-on: https://review.coreboot.org/16218
    Tested-by: build bot (Jenkins)
    Reviewed-by: Aaron Durbin <adurbin at chromium.org>


See https://review.coreboot.org/16218 for details.

-gerrit



More information about the coreboot-gerrit mailing list