[coreboot-gerrit] New patch to review for coreboot: intel/quark: Fix assert check

[Furquan Shaikh (furquan@google.com)]

Furquan Shaikh (furquan at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16219

-gerrit

commit 6ae504ebc8ab02ed178073be8f989a61df606c3f
Author: Furquan Shaikh <furquan at google.com>
Date:   Sun Aug 14 21:59:03 2016 -0700

    intel/quark: Fix assert check
    
    Having an assignment in assert does not make sense. This seems like it
    was intended to check if chip is always same as segments->chip.
    
    Change-Id: I297d9e76a0404a1f510d43f8b9c39e96b557689f
    Reported-by: Coverity ID 1357439
    Signed-off-by: Furquan Shaikh <furquan at google.com>
---
 src/soc/intel/quark/i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/soc/intel/quark/i2c.c b/src/soc/intel/quark/i2c.c
index 6465b66..6b1f6dd 100644
--- a/src/soc/intel/quark/i2c.c
+++ b/src/soc/intel/quark/i2c.c
@@ -101,7 +101,7 @@ int platform_i2c_transfer(unsigned bus, struct i2c_seg *segments, int count)
 		length = segments->len;
 		ASSERT (buffer != NULL);
 		ASSERT (length >= 1);
-		ASSERT (segments->chip = chip);
+		ASSERT (segments->chip == chip);
 
 		if (segments->read) {
 			/* Place read commands into the FIFO */