[coreboot-gerrit] New patch to review for coreboot: drivers/intel/fsp2_0: Fix FSP reset path

[Lee Leahy (leroy.p.leahy@intel.com)]

Lee Leahy (leroy.p.leahy at intel.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16162

-gerrit

commit 2f6860a0dfcfc9a87576d4cde883378d501edf57
Author: Lee Leahy <leroy.p.leahy at intel.com>
Date:   Thu Aug 11 17:40:01 2016 -0700

    drivers/intel/fsp2_0: Fix FSP reset path
    
    Don't verify HOB list pointer or HOBs when FSP returns a reset request.
    
    Fixes chrome-os-partner bug number 56159
    
    BRANCH=none
    BUG=None
    TEST=Build and run on Galileo Gen2.
    
    Change-Id: I6382f5ff92092623955806ebff340608c4ee156a
    Signed-off-by: Lee Leahy <Leroy.P.Leahy at intel.com>
---
 src/drivers/intel/fsp2_0/debug.c | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/src/drivers/intel/fsp2_0/debug.c b/src/drivers/intel/fsp2_0/debug.c
index 6d88f02..709d2ab 100644
--- a/src/drivers/intel/fsp2_0/debug.c
+++ b/src/drivers/intel/fsp2_0/debug.c
@@ -49,19 +49,21 @@ void fsp_debug_after_memory_init(enum fsp_status status)
 	if (IS_ENABLED(CONFIG_DISPLAY_FSP_CALLS_AND_STATUS))
 		printk(BIOS_SPEW, "FspMemoryInit returned 0x%08x\n", status);
 
-	/* Verify that the HOB list pointer was set */
-	if (fsp_get_hob_list() == NULL)
-		die("ERROR - HOB list pointer was not returned!\n");
-
-	/* Display and verify the HOBs */
-	if (IS_ENABLED(CONFIG_DISPLAY_HOBS))
-		fsp_display_hobs();
-	if (IS_ENABLED(CONFIG_VERIFY_HOBS))
-		fsp_verify_memory_init_hobs();
-
-	/* Display the MTRRs */
-	if (IS_ENABLED(CONFIG_DISPLAY_MTRRS))
-		soc_display_mtrrs();
+	if (status == FSP_SUCCESS) {
+		/* Verify that the HOB list pointer was set */
+		if (fsp_get_hob_list() == NULL)
+			die("ERROR - HOB list pointer was not returned!\n");
+
+		/* Display and verify the HOBs */
+		if (IS_ENABLED(CONFIG_DISPLAY_HOBS))
+			fsp_display_hobs();
+		if (IS_ENABLED(CONFIG_VERIFY_HOBS))
+			fsp_verify_memory_init_hobs();
+
+		/* Display the MTRRs */
+		if (IS_ENABLED(CONFIG_DISPLAY_MTRRS))
+			soc_display_mtrrs();
+	}
 }
 
 /*-----------