[coreboot-gerrit] New patch to review for coreboot: Revert "gru: Show the current time on start-up"

[Martin Roth (martinroth@google.com)]

Martin Roth (martinroth at google.com) just uploaded a new patch set to gerrit, which you can find at https://review.coreboot.org/16153

-gerrit

commit ccd5c29cd8db2bc9a88d56b3671b4f244618c48c
Author: Julius Werner <jwerner at chromium.org>
Date:   Tue Aug 9 13:23:02 2016 -0700

    Revert "gru: Show the current time on start-up"
    
    This reverts commit 850e45f19f498eedd80da4a97a5ce641e2cec6d5.
    
    google_chromeec_init() is a weird function that can lead to confusing
    behavior. I'm not sure how it's meant to work on the boards that use it,
    but it causes problems on Kevin and other non-x86 boards have never used
    it either. It doesn't really do anything anyway (the EC works fine
    without an initial HELLO), so at best it's just a waste of time... let's
    take it back out.
    
    There's also no need to display the current time on every boot... other
    boards don't do that and the eventlog already fills the same purpose.
    Cut it out to avoid one extra host command overhead.
    
    BRANCH=None
    BUG=chrome-os-partner:55995
    TEST=Recovery reasons now get correctly propagated across the EC reboot.
    
    Change-Id: Ic3b772780d4d05e362c269969e6e4e7069482bb6
    Signed-off-by: Martin Roth <martinroth at chromium.org>
    Original-Commit-Id: 103d86e68cd164bea39aa1edc8668d80358edbde
    Original-Change-Id: I58fd5e6094e1c8cb6368e7a4569ab9231375fbc9
    Original-Signed-off-by: Julius Werner <jwerner at chromium.org>
    Original-Reviewed-on: https://chromium-review.googlesource.com/367351
    Original-Reviewed-by: Simon Glass <sjg at chromium.org>
    Original-Reviewed-by: Shelley Chen <shchen at chromium.org>
---
 src/mainboard/google/gru/mainboard.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/src/mainboard/google/gru/mainboard.c b/src/mainboard/google/gru/mainboard.c
index 1f33ed1..8e95794 100644
--- a/src/mainboard/google/gru/mainboard.c
+++ b/src/mainboard/google/gru/mainboard.c
@@ -18,10 +18,7 @@
 #include <delay.h>
 #include <device/device.h>
 #include <device/i2c.h>
-#include <ec/google/chromeec/ec.h>
-#include <elog.h>
 #include <gpio.h>
-#include <rtc.h>
 #include <soc/bl31_plat_params.h>
 #include <soc/clock.h>
 #include <soc/display.h>
@@ -165,17 +162,6 @@ static void setup_usb(void)
 	setup_usb_drd1_dwc3();
 }
 
-static void setup_rtc(void)
-{
-	struct rtc_time time;
-	int ret;
-
-	/* Show the current time to see that the EC RTC is working */
-	google_chromeec_init();
-	ret = rtc_get(&time);
-	rtc_display(&time);
-}
-
 static void mainboard_init(device_t dev)
 {
 	configure_sdmmc();
@@ -185,7 +171,6 @@ static void mainboard_init(device_t dev)
 	setup_usb();
 	register_reset_to_bl31();
 	register_poweroff_to_bl31();
-	setup_rtc();
 }
 
 static void enable_backlight_booster(void)